Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(da-eigen-implementation-m0): merge main #316

Draft
wants to merge 18 commits into
base: da-eigen-implementation-m0
Choose a base branch
from

Conversation

juan518munoz
Copy link

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk_supervisor fmt and zk_supervisor lint.

yorik and others added 3 commits October 30, 2024 11:20
…er-labs#3196)

## What ❔

<!-- What are the changes this PR brings about? -->
<!-- Example: This PR adds a PR template to the repo. -->
<!-- (For bigger PRs adding more context is appreciated) -->

## Why ❔

<!-- Why are these changes done? What goal do they contribute to? What
are the principles behind them? -->
<!-- Example: PR templates ensure PR reviewers, observers, and future
iterators are in context about the evolution of repos. -->

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev
lint`.

---------

Co-authored-by: Manuel Mauro <[email protected]>
…abs#3194)

## What ❔

Add sending scale requests for Scaler targets.
Add dry-run config option for Scaler.

<!-- What are the changes this PR brings about? -->
<!-- Example: This PR adds a PR template to the repo. -->
<!-- (For bigger PRs adding more context is appreciated) -->

## Why ❔

<!-- Why are these changes done? What goal do they contribute to? What
are the principles behind them? -->
<!-- Example: PR templates ensure PR reviewers, observers, and future
iterators are in context about the evolution of repos. -->

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [x] Code has been formatted via `zkstack dev fmt` and `zkstack dev
lint`.


ref ZKD-1855

---------

Co-authored-by: Manuel Mauro <[email protected]>
cytadela8 and others added 2 commits October 30, 2024 15:13
## What ❔

- Introduce 2 new tests for base token:
    - gas calculation
    - proper application of dynamic changes to base token ratio
- Improve forced price client fluctuations implementation to limit
difference between consecutive values.

## Why ❔

- We want better integration test coverage of custom base token

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [x] Tests for the changes have been added / updated.
- [x] Documentation comments have been added / updated.
- [x] Code has been formatted via `zk fmt` and `zk lint`.

---------

Co-authored-by: Ivan Schasny <[email protected]>
## What ❔

Enable `tls-roots` feature in `tonic` crate.


## Why ❔

Without this feature, the connection with the Eigen disperser can't be
established

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [ ] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev
lint`.
Base automatically changed from da-eigen-implementation-m0-revert-changes to da-eigen-implementation-m0 October 30, 2024 17:41
dimazhornyk and others added 13 commits October 30, 2024 18:19
…labs#3203)

## What ❔

Add the padding to the blob data in EigenDA client

## Why ❔

The unpadded larger blobs can't be decoded by the EigenDA disperser.

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [ ] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev
lint`.
## What ❔

Removes all stale keys for the "future" tree versions during truncation.

## Why ❔

Otherwise, we may get bogus stale keys and non-stale nodes removed from
the tree during pruning.

## Checklist

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [x] Tests for the changes have been added / updated.
- [x] Documentation comments have been added / updated.
- [x] Code has been formatted via `zkstack dev fmt` and `zkstack dev
lint`.
🤖 I have created a release *beep* *boop*
---


##
[16.6.0](matter-labs/zksync-era@prover-v16.5.0...prover-v16.6.0)
(2024-10-31)


### Features

* (DB migration) Rename recursion_scheduler_level_vk_hash to
snark_wrapper_vk_hash
([matter-labs#2809](matter-labs#2809))
([64f9551](matter-labs@64f9551))
* Add initial version prover_autoscaler
([matter-labs#2993](matter-labs#2993))
([ebf9604](matter-labs@ebf9604))
* added seed_peers to consensus global config
([matter-labs#2920](matter-labs#2920))
([e9d1d90](matter-labs@e9d1d90))
* attester committees data extractor (BFT-434)
([matter-labs#2684](matter-labs#2684))
([92dde03](matter-labs@92dde03))
* Bump crypto and protocol deps
([matter-labs#2825](matter-labs#2825))
([a5ffaf1](matter-labs@a5ffaf1))
* **circuit_prover:** Add circuit prover
([matter-labs#2908](matter-labs#2908))
([48317e6](matter-labs@48317e6))
* **consensus:** Support for syncing blocks before consensus genesis
over p2p network
([matter-labs#3040](matter-labs#3040))
([d3edc3d](matter-labs@d3edc3d))
* **da-clients:** add secrets
([matter-labs#2954](matter-labs#2954))
([f4631e4](matter-labs@f4631e4))
* gateway preparation
([matter-labs#3006](matter-labs#3006))
([16f2757](matter-labs@16f2757))
* Integrate tracers and implement circuits tracer in vm2
([matter-labs#2653](matter-labs#2653))
([87b02e3](matter-labs@87b02e3))
* Move prover data to
/home/popzxc/workspace/current/zksync-era/prover/data
([matter-labs#2778](matter-labs#2778))
([62e4d46](matter-labs@62e4d46))
* Prover e2e test
([matter-labs#2975](matter-labs#2975))
([0edd796](matter-labs@0edd796))
* **prover:** add CLI option to run prover with max allocation
([matter-labs#2794](matter-labs#2794))
([35e4cae](matter-labs@35e4cae))
* **prover:** Add endpoint to PJM to get queue reports
([matter-labs#2918](matter-labs#2918))
([2cec83f](matter-labs@2cec83f))
* **prover:** Add error to panic message of prover
([matter-labs#2807](matter-labs#2807))
([6e057eb](matter-labs@6e057eb))
* **prover:** Add min_provers and dry_run features. Improve metrics and
test. ([matter-labs#3129](matter-labs#3129))
([7c28964](matter-labs@7c28964))
* **prover:** Add scale failure events watching and pods eviction.
([matter-labs#3175](matter-labs#3175))
([dd166f8](matter-labs@dd166f8))
* **prover:** Add sending scale requests for Scaler targets
([matter-labs#3194](matter-labs#3194))
([767c5bc](matter-labs@767c5bc))
* **prover:** Add support for scaling WGs and compressor
([matter-labs#3179](matter-labs#3179))
([c41db9e](matter-labs@c41db9e))
* **prover:** Autoscaler sends scale request to appropriate agents.
([matter-labs#3150](matter-labs#3150))
([bfedac0](matter-labs@bfedac0))
* **prover:** Extract keystore into a separate crate
([matter-labs#2797](matter-labs#2797))
([e239260](matter-labs@e239260))
* **prover:** Optimize setup keys loading
([matter-labs#2847](matter-labs#2847))
([19887ef](matter-labs@19887ef))
* **prover:** Refactor WitnessGenerator
([matter-labs#2845](matter-labs#2845))
([934634b](matter-labs@934634b))
* **prover:** Update witness generator to zkevm_test_harness 0.150.6
([matter-labs#3029](matter-labs#3029))
([2151c28](matter-labs@2151c28))
* **prover:** Use query macro instead string literals for queries
([matter-labs#2930](matter-labs#2930))
([1cf959d](matter-labs@1cf959d))
* **prover:** WG refactoring
[#3](matter-labs#3)
([matter-labs#2942](matter-labs#2942))
([df68762](matter-labs@df68762))
* **prover:** WitnessGenerator refactoring
[#2](matter-labs#2)
([matter-labs#2899](matter-labs#2899))
([36e5340](matter-labs@36e5340))
* Refactor metrics/make API use binaries
([matter-labs#2735](matter-labs#2735))
([8ed086a](matter-labs@8ed086a))
* Remove prover db from house keeper
([matter-labs#2795](matter-labs#2795))
([85b7346](matter-labs@85b7346))
* **tee:** use hex serialization for RPC responses
([matter-labs#2887](matter-labs#2887))
([abe0440](matter-labs@abe0440))
* **utils:** Rework locate_workspace, introduce Workspace type
([matter-labs#2830](matter-labs#2830))
([d256092](matter-labs@d256092))
* vm2 tracers can access storage
([matter-labs#3114](matter-labs#3114))
([e466b52](matter-labs@e466b52))
* **vm:** Do not panic on VM divergence
([matter-labs#2705](matter-labs#2705))
([7aa5721](matter-labs@7aa5721))
* **vm:** EVM emulator support – base
([matter-labs#2979](matter-labs#2979))
([deafa46](matter-labs@deafa46))
* **vm:** Extract batch executor to separate crate
([matter-labs#2702](matter-labs#2702))
([b82dfa4](matter-labs@b82dfa4))
* **zk_toolbox:** `zk_supervisor prover` subcommand
([matter-labs#2820](matter-labs#2820))
([3506731](matter-labs@3506731))
* **zk_toolbox:** Add external_node consensus support
([matter-labs#2821](matter-labs#2821))
([4a10d7d](matter-labs@4a10d7d))
* **zk_toolbox:** Add SQL format for zk supervisor
([matter-labs#2950](matter-labs#2950))
([540e5d7](matter-labs@540e5d7))
* **zk_toolbox:** deploy legacy bridge
([matter-labs#2837](matter-labs#2837))
([93b4e08](matter-labs@93b4e08))
* **zk_toolbox:** Redesign zk_toolbox commands
([matter-labs#3003](matter-labs#3003))
([114834f](matter-labs@114834f))
* **zkstack_cli:** Build dependencies at zkstack build time
([matter-labs#3157](matter-labs#3157))
([724d9a9](matter-labs@724d9a9))


### Bug Fixes

* allow compilation under current toolchain
([matter-labs#3176](matter-labs#3176))
([89eadd3](matter-labs@89eadd3))
* **api:** Return correct flat call tracer
([matter-labs#2917](matter-labs#2917))
([218646a](matter-labs@218646a))
* count SECP256 precompile to account validation gas limit as well
([matter-labs#2859](matter-labs#2859))
([fee0c2a](matter-labs@fee0c2a))
* Fix Doc lint.
([matter-labs#3158](matter-labs#3158))
([c79949b](matter-labs@c79949b))
* ignore unknown fields in rpc json response
([matter-labs#2962](matter-labs#2962))
([692ea73](matter-labs@692ea73))
* **prover:** Do not exit on missing watcher data.
([matter-labs#3119](matter-labs#3119))
([76ed6d9](matter-labs@76ed6d9))
* **prover:** fix setup_metadata_to_setup_data_key
([matter-labs#2875](matter-labs#2875))
([4ae5a93](matter-labs@4ae5a93))
* **prover:** Run for zero queue to allow scaling down to 0
([matter-labs#3115](matter-labs#3115))
([bbe1919](matter-labs@bbe1919))
* **tee_verifier:** correctly initialize storage for re-execution
([matter-labs#3017](matter-labs#3017))
([9d88373](matter-labs@9d88373))
* **vm:** Prepare new VM for use in API server and fix divergences
([matter-labs#2994](matter-labs#2994))
([741b77e](matter-labs@741b77e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop*
---


##
[17.0.0](matter-labs/zksync-era@prover-v16.6.0...prover-v17.0.0)
(2024-10-31)


### ⚠ BREAKING CHANGES

* force minor bump for provers release -- v25
([matter-labs#3208](matter-labs#3208))

### Features

* force minor bump for provers release -- v25
([matter-labs#3208](matter-labs#3208))
([6851e35](matter-labs@6851e35))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
matter-labs#3206)

## What ❔
Add `queue` metric to report autoscaler view of the queue.
Add Copy trait for QueueReportFields and remove unneeded clone or
references.

<!-- What are the changes this PR brings about? -->
<!-- Example: This PR adds a PR template to the repo. -->
<!-- (For bigger PRs adding more context is appreciated) -->

## Why ❔

The `queue` metric will be used in dashboards.

<!-- Why are these changes done? What goal do they contribute to? What
are the principles behind them? -->
<!-- Example: PR templates ensure PR reviewers, observers, and future
iterators are in context about the evolution of repos. -->

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [x] Code has been formatted via `zkstack dev fmt` and `zkstack dev
lint`.

ref ZKD-1855
## What ❔

Supports EVM emulation if it is signaled via `SystemEnv`.

## Why ❔

Fast VM should have feature parity with the legacy VM.

## Checklist

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [x] Tests for the changes have been added / updated.
- [x] Documentation comments have been added / updated.
- [x] Code has been formatted via `zkstack dev fmt` and `zkstack dev
lint`.
…ter-labs#3204)

Currently, successful validations are reported as reverts, which is
super confusing.

Why this is safe:
- `TracerExecutionStopReason::Finished` is only emitted on success,
Errors always emit Abort instead
- Some of the removed code was just dead code. `self.result` was checked
twice.

I'd rather fix the strange behaviour than emulate it to make ShadowVm
line up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants