Remove unwrap in transaction receipt rpc call #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulianGCalderon
changed the title
JulianGCalderon
requested review from
edg-l,
igaray,
azteca1998,
fmoletta and
pefontana
as code owners
edg-l
approved these changes
Oct 28, 2024
FrancoGiachetta
approved these changes
Oct 29, 2024
pefontana
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting the transaction receipt can fail. If it fails, an error message is logged and the execution continues. If it doesn't failed, the transaction result is compare to rpc, as usual.
To do this, I moved all the compare logic to a new function
compare_executionand only calls it if the receipt can be retreived.Depends on #77