-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clash count to benchmarks #42
base: main
Are you sure you want to change the base?
Conversation
✅ Code is now correctly formatted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now, the class_hash
and entry_point
information are only associated to the execution summary and, if we ever want to analyze and plot this information) there is no easy way to link them to the execution time (they are in different events on the same span).
I think it's better if, instead, you record that information into the span (_tx_span
). If there is a way to get the class hash and the entry point before the execution, you can add it directly, if this is not possible, you can use this method: https://docs.rs/tracing/latest/tracing/struct.Span.html#method.record to record it afterwards.
Ask me If you have any questions about this.
Might be a way to gather the entrypoint through the transaction's calldata. But I think it´s more redable to leave as it is now and use that record method you were talking about. |
@FrancoGiachetta can you resolve the conflicts on this branch? |
This PR adds the class hash call to the logs for each transaction, with its entrypoint, during block range's benchmark execution.