-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate constraints in black box functions #74
base: main
Are you sure you want to change the base?
Commits on Mar 17, 2023
-
Due to the new fixed bugs, new test programs could run properly using our backend
Configuration menu - View commit details
-
Copy full SHA for f4c226e - Browse repository at this point
Copy the full SHA f4c226eView commit details -
Configuration menu - View commit details
-
Copy full SHA for c34d2a0 - Browse repository at this point
Copy the full SHA c34d2a0View commit details -
Merge branch 'main' of github.com:lambdaclass/noir_backend_using_gnar…
…k into update_test_programs
Configuration menu - View commit details
-
Copy full SHA for 84168be - Browse repository at this point
Copy the full SHA 84168beView commit details -
Configuration menu - View commit details
-
Copy full SHA for db02fac - Browse repository at this point
Copy the full SHA db02facView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5da78de - Browse repository at this point
Copy the full SHA 5da78deView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0fe4cba - Browse repository at this point
Copy the full SHA 0fe4cbaView commit details -
Configuration menu - View commit details
-
Copy full SHA for a0fa660 - Browse repository at this point
Copy the full SHA a0fa660View commit details -
Configuration menu - View commit details
-
Copy full SHA for e52ea33 - Browse repository at this point
Copy the full SHA e52ea33View commit details -
Configuration menu - View commit details
-
Copy full SHA for aa0fe58 - Browse repository at this point
Copy the full SHA aa0fe58View commit details -
Configuration menu - View commit details
-
Copy full SHA for ce7aed3 - Browse repository at this point
Copy the full SHA ce7aed3View commit details -
Configuration menu - View commit details
-
Copy full SHA for bef6ec9 - Browse repository at this point
Copy the full SHA bef6ec9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d17777 - Browse repository at this point
Copy the full SHA 1d17777View commit details -
Configuration menu - View commit details
-
Copy full SHA for 63d2dcf - Browse repository at this point
Copy the full SHA 63d2dcfView commit details -
Configuration menu - View commit details
-
Copy full SHA for f094f24 - Browse repository at this point
Copy the full SHA f094f24View commit details
Commits on Mar 20, 2023
-
Handle some black box functions
- AND - XOR - RANGE - SHA256 - Blake2s - HashToField128Security - EcdsaSecp256k1
Configuration menu - View commit details
-
Copy full SHA for b93b61d - Browse repository at this point
Copy the full SHA b93b61dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2996fa1 - Browse repository at this point
Copy the full SHA 2996fa1View commit details
Commits on Mar 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 292f6d3 - Browse repository at this point
Copy the full SHA 292f6d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 89f2ce9 - Browse repository at this point
Copy the full SHA 89f2ce9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 34a828b - Browse repository at this point
Copy the full SHA 34a828bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0cfb20c - Browse repository at this point
Copy the full SHA 0cfb20cView commit details -
Configuration menu - View commit details
-
Copy full SHA for c55ccfc - Browse repository at this point
Copy the full SHA c55ccfcView commit details
Commits on Mar 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ff46497 - Browse repository at this point
Copy the full SHA ff46497View commit details
Commits on Mar 27, 2023
-
assertIsBoolean
component (#71)* Add first implementation of gadget * Update gnark_backend_ffi/backend/plonk/components.go * Update gnark_backend_ffi/backend/plonk/components.go * Update gnark_backend_ffi/backend/plonk/components.go * Update gnark_backend_ffi/backend/plonk/components.go * Add function to get the one wire's index * Fix function signature * Improve documentation * Add secret variables instead of internal ones for the intermediate variables * Return the mutated secret variables * Refactor a function (abstract it from the ACIR) * Add tests for `assertIsBoolean` component * Fix `assertIsBoolean` constraint component * Remove useless function * Update naming * Fix
Configuration menu - View commit details
-
Copy full SHA for 56f8e93 - Browse repository at this point
Copy the full SHA 56f8e93View commit details
Commits on Mar 30, 2023
-
* Add first implementation of gadget * Update gnark_backend_ffi/backend/plonk/components.go * Update gnark_backend_ffi/backend/plonk/components.go * Update gnark_backend_ffi/backend/plonk/components.go * Update gnark_backend_ffi/backend/plonk/components.go * Add function to get the one wire's index * Fix function signature * Improve documentation * Add secret variables instead of internal ones for the intermediate variables * Return the mutated secret variables * Refactor a function (abstract it from the ACIR) * Add tests for `assertIsBoolean` component * Add tests for bit and component * Add bit and component * Add multiple-bit and component * Update result's secret variable name * Fix `assertIsBoolean` constraint component * Remove useless function * Update naming * Fix * Add `assertIsEqual` component * Refactor repeated code in tests * Add `assertIsEqual` component tests * Implement `add` `mul` & `assertIsEqual` components * Fix `toBinaryConversion` component * Update secret variables naming * Add `toBinaryConversion` tests * Remove print * Add missing boolean assertion when converting to binary * Improve variable labels * Fix `toBinaryConversion` * Flag to generate constraint over `and` inputs * Update `And` * Shift coefficient after every iteration * Implement `fromBinaryConversion` component * Update tests naming * Finish `And` implementation * Update `accumulator` label name * Remove needless boolean assertion It is asserted above * Document components * Cleanup components * Rename module * Doc `assertIsEqual`
Configuration menu - View commit details
-
Copy full SHA for a100932 - Browse repository at this point
Copy the full SHA a100932View commit details -
* Add first implementation of gadget * Update gnark_backend_ffi/backend/plonk/components.go * Update gnark_backend_ffi/backend/plonk/components.go * Update gnark_backend_ffi/backend/plonk/components.go * Update gnark_backend_ffi/backend/plonk/components.go * Add function to get the one wire's index * Fix function signature * Improve documentation * Add secret variables instead of internal ones for the intermediate variables * Return the mutated secret variables * Refactor a function (abstract it from the ACIR) * Add tests for `assertIsBoolean` component * Add tests for bit and component * Add bit and component * Add multiple-bit and component * Update result's secret variable name * Add xor component implementation Both for bit-to-bit and multiple bits * Fix append * Add tests for single bit xor * Fix `assertIsBoolean` constraint component * Remove useless function * Update naming * Fix * Add `assertIsEqual` component * Refactor repeated code in tests * Add `assertIsEqual` component tests * Implement `add` `mul` & `assertIsEqual` components * Fix `toBinaryConversion` component * Update secret variables naming * Add `toBinaryConversion` tests * Remove print * Add missing boolean assertion when converting to binary * Improve variable labels * Fix `toBinaryConversion` * Flag to generate constraint over `and` inputs * Update `And` * Shift coefficient after every iteration * Implement `fromBinaryConversion` component * Update tests naming * Finish `And` implementation * Update `accumulator` label name * Remove needless boolean assertion It is asserted above * Document components * Cleanup components * Rename module * Doc `assertIsEqual` * Finish `Xor` & `xor` components implementations * Update doc
Configuration menu - View commit details
-
Copy full SHA for 69ccd6f - Browse repository at this point
Copy the full SHA 69ccd6fView commit details -
Integrate
AND
andXOR
black box functions (#75)* Add first implementation of gadget * Update gnark_backend_ffi/backend/plonk/components.go * Update gnark_backend_ffi/backend/plonk/components.go * Update gnark_backend_ffi/backend/plonk/components.go * Update gnark_backend_ffi/backend/plonk/components.go * Add function to get the one wire's index * Fix function signature * Improve documentation * Add secret variables instead of internal ones for the intermediate variables * Return the mutated secret variables * Refactor a function (abstract it from the ACIR) * Add tests for `assertIsBoolean` component * Add tests for bit and component * Add bit and component * Add multiple-bit and component * Update result's secret variable name * Add xor component implementation Both for bit-to-bit and multiple bits * Fix append * Add tests for single bit xor * Fix `assertIsBoolean` constraint component * Remove useless function * Update naming * Fix * Add `assertIsEqual` component * Refactor repeated code in tests * Add `assertIsEqual` component tests * Implement `add` `mul` & `assertIsEqual` components * Fix `toBinaryConversion` component * Update secret variables naming * Add `toBinaryConversion` tests * Remove print * Add missing boolean assertion when converting to binary * Improve variable labels * Fix `toBinaryConversion` * Flag to generate constraint over `and` inputs * Update `And` * Shift coefficient after every iteration * Implement `fromBinaryConversion` component * Update tests naming * Finish `And` implementation * Update `accumulator` label name * Remove needless boolean assertion It is asserted above * Document components * Cleanup components * Rename module * Doc `assertIsEqual` * Finish `Xor` & `xor` components implementations * Update doc * Update variable usage In the previous iteration, only secret variables were assumed to be the only ones used for the component. In reality, both secret and public variables could be used with components. Given that in components, the intermediate variables are treated as secret, then we must track them, but we also need to use the full variables vector (public+secret in order). This is just another iteration, it seems that having some mutable Context data structure would clean the code a lot, because it is really messy as it is and the user must take care of updating the secret, and the full variables vectors. * `HandleValues` returns a full variables vector too Public + secret in order * Both `handleOpcodes`and `handleBlackBoxFunctionOpcode` must now return the added secret variables (that are the internal ones). If we manage to handle these internal variables as internal and not as secret, this would be useless. * First iteration of integrating AND & XOR opcodes On this iteration we do not handle the `variablesMap` and we do not compare the incoming output with the computed one. * Bring back Go tests At the moment we're just running Plonk's components tests because the ACIR's are to be fixed * Update package name * Sort imports * Update imports * Add missing function * `Context` refactor (#76) * Add `Context` * Handle `Context` in components * Update tests * Comment out `go` job until fixed * Temporarily fix integration For some reason, having a third level module (`components`) makes the `cc` crate not to compile when building `nargo`. It seems that the module is not being found.
Configuration menu - View commit details
-
Copy full SHA for 0c97afe - Browse repository at this point
Copy the full SHA 0c97afeView commit details
Commits on Mar 31, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d91495c - Browse repository at this point
Copy the full SHA d91495cView commit details
Commits on Mar 8, 2024
-
Merge branch 'main' of github.com:lambdaclass/noir_backend_using_gnar…
…k into generate_constraints_in_black_box_functions
Configuration menu - View commit details
-
Copy full SHA for 15fb7d4 - Browse repository at this point
Copy the full SHA 15fb7d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7aeec13 - Browse repository at this point
Copy the full SHA 7aeec13View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0aabeb0 - Browse repository at this point
Copy the full SHA 0aabeb0View commit details