Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add from Circom to Lambdaworks example #931

Merged
merged 6 commits into from
Oct 23, 2024
Merged

Conversation

jotabulacios
Copy link
Contributor

@jotabulacios jotabulacios commented Oct 16, 2024

Add from Circom to Lambdaworks example

Description

Small PR adding a walkthrough tutorial to create a circuit in Circom, generate a proof, and verify it using with Groth16 using Lambdaworks

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.08%. Comparing base (21a02da) to head (ce80fee).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #931   +/-   ##
=======================================
  Coverage   71.08%   71.08%           
=======================================
  Files         144      144           
  Lines       31824    31824           
=======================================
  Hits        22622    22622           
  Misses       9202     9202           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jotabulacios jotabulacios marked this pull request as ready for review October 16, 2024 19:56
@jotabulacios jotabulacios requested a review from a team as a code owner October 16, 2024 19:56
That will create a `fibonacci_js` directory and a `fibonacci_r1cs `file

> [!WARNING]
> Do not skip the -p bls12381 flag as this is the only field supported by the adapter right now. If not specified the default is bn128 and the proving will not be possible
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add support for bn254 eventually

@ColoCarletti ColoCarletti added this pull request to the merge queue Oct 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 23, 2024
@diegokingston diegokingston added this pull request to the merge queue Oct 23, 2024
Merged via the queue into main with commit e14cf2b Oct 23, 2024
8 checks passed
@diegokingston diegokingston deleted the add_circom_example branch October 23, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants