Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backend): Add Icicle as a GPU backend #800

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

PatStiles
Copy link
Collaborator

Add Icicle as a GPU backend

Description

This pr adds wrappers for conversion of lambaworks types -> Icicle types and adds methods to interface with the Icicle GPU backend. Upstreaming this conversion into the Icicle repo would remove much of the boilerplate. Closes #353

Type of change

  • New feature

Checklist

  • Linked to Github Issue
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run

@PatStiles PatStiles requested a review from a team as a code owner February 5, 2024 02:02
@PatStiles PatStiles marked this pull request as draft February 5, 2024 02:02
@PatStiles PatStiles marked this pull request as ready for review February 21, 2024 09:36
@PatStiles PatStiles force-pushed the feat/icicle branch 2 times, most recently from 7074929 to 76d2d6a Compare February 21, 2024 15:47
@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.55%. Comparing base (601ab67) to head (8e898ad).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #800   +/-   ##
=======================================
  Coverage   94.55%   94.55%           
=======================================
  Files         154      154           
  Lines       34587    34587           
=======================================
  Hits        32705    32705           
  Misses       1882     1882           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@diegokingston diegokingston added this pull request to the merge queue Mar 6, 2024
@diegokingston diegokingston removed this pull request from the merge queue due to a manual request Mar 6, 2024
@MauroToscano
Copy link
Collaborator

For some reason it's not compiling locally.

failed to select a version for rayon.
... required by package icicle-core v1.4.0 (https://github.com/ingonyama-zk/icicle.git?tag=v1.4.0#15a63cc5)
... which satisfies git dependency icicle-core of package lambdaworks-math v0.5.0 (/Users/maurofab/workspace/lambdaworks/math)
... which satisfies path dependency lambdaworks-math (locked to 0.5.0) of package arkworks_adapter v0.5.0 (/Users/maurofab/workspace/lambdaworks/provers/groth16/arkworks-adapter)
versions that meet the requirements ^1.8.1 are: 1.9.0, 1.8.1

I'll investigate this a bit

Copy link
Collaborator

@MauroToscano MauroToscano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Investigate compilation error


lambdaworks-gpu = { workspace = true, optional = true }

[dev-dependencies]
rand = { version = "0.8.5", default-features = false }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be optional. It may not work with no std.

@PatStiles PatStiles force-pushed the feat/icicle branch 2 times, most recently from dff2bd3 to cedb7e4 Compare March 9, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow using Icicle
4 participants