Stark: Prover and Verifier over field extensions v3 #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #724 +/- ##
==========================================
- Coverage 95.66% 95.63% -0.04%
==========================================
Files 136 136
Lines 30672 30882 +210
==========================================
+ Hits 29342 29533 +191
- Misses 1330 1349 +19 ☔ View full report in Codecov by Sentry. |
diegokingston
approved these changes
Dec 21, 2023
|
Round 2 has a slowdown of around 2%
We should explore this a bit |
After double checking, it seems this version is faster. Incredible PR |
MauroToscano
approved these changes
Dec 22, 2023
entropidelic
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prover and Verifier over field extensions v3
Description
This is the last PR in the series to refactor the Prover and Verifier to use field extensions. This PR modifies the tables and frames to be aware of different fields coming from evaluations of main (base field) and auxiliary trace (field extension) columns. This PR includes:
EvaluationTablestruct that can hold main and auxiliary evaluation tables that take values in different fields.Framestruct to hold main and auxiliary evaluations in the same spirit.