-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crypto: Remove repeated code in Merkle tree backends #584
Conversation
Codecov Report
@@ Coverage Diff @@
## main #584 +/- ##
=======================================
Coverage 95.49% 95.49%
=======================================
Files 112 110 -2
Lines 19008 18966 -42
=======================================
- Hits 18151 18111 -40
+ Misses 857 855 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can find a better name for singlebackend ?
its indeed an ugly name. Other options I considered are:
|
I think 1 Is nice. Also FEVector is more descriptive than Batch. We can change that change later though, I don't mind |
Remove repeated code in Merkle tree backends
Description
This PR leverages const generics to remove repeated code in
crypto/src/merkle_tree/backends
. We previously had two separate implementations for 256 and 512 bit in both batched and single element backends. This PR merges both into a single implementation for batch and a single implementation for single elements.Type of change