-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Babybear field FFT friendly #576
Make Babybear field FFT friendly #576
Conversation
017d391
to
9fe3a06
Compare
Now all fft tests work but the |
There's a bug with how the CUDA and Metal is used. It's assuming that if the feature is enabled, it can run with CUDA or Metal. As a quickfix, you can add this in the relevant tests |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #576 +/- ##
==========================================
- Coverage 96.16% 96.14% -0.03%
==========================================
Files 132 133 +1
Lines 29904 29812 -92
==========================================
- Hits 28758 28662 -96
- Misses 1146 1150 +4 ☔ View full report in Codecov by Sentry. |
Make Babybear field FFT friendly
Description
Implemented
isFFT
trait to babybear field as requested in issue #539. Here the constantsTWO_ADIC_PRIMITVE_ROOT_OF_UNITY
andTWO_ADICITY
were updated accordingly.Type of change
Checklist