Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

todo: implement getters in plonk setup #555

Closed

Conversation

dbejarano820
Copy link
Contributor

Getters in plonk setup

Description

Browsing through the code I noticed a simple ToDo task which is what this PR solves.
I'll complete the other ToDo in a separate PR which involves removing unwraps in the from_constraint_system function in this same file.

Type of change

  • ToDo task

Checklist

  • Linked to Github Issue
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run

@MauroToscano
Copy link
Collaborator

We don't use getters in the library. And the attributes are public. Seems like an odd TO DO. I'd avoid adding them. Let me check with the rest of the team.

@MauroToscano
Copy link
Collaborator

For the time being we shouldn't do this. If you want to remove the comment with the TO DO we can do that.

We will include getters for private attributes, but as you have seen most of the repo functions and structs are public.

Before the main release we will review the visibility of functions making pub (crate) most of them, and then expose getters as needed. This will avoid breaking changes for people using the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants