perf: use overflowing_add for UnsignedInteger::add #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows using only `u64` variables and gives a bit more information
to the compiler about our intent.
Results on M1 with 16GB:
```
add 1M elements | lambdaworks
time: [7.0109 ms 7.0278 ms 7.0465 ms]
change: [-29.850% -29.645% -29.430%] (p = 0.00 < 0.01)
Performance has improved.
```
diegokingston
approved these changes
Aug 7, 2023
MauroToscano
approved these changes
Aug 10, 2023
Codecov Report
@@ Coverage Diff @@
## main #521 +/- ##
=======================================
Coverage 94.52% 94.52%
=======================================
Files 62 62
Lines 8963 8964 +1
=======================================
+ Hits 8472 8473 +1
Misses 491 491
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows using only
u64variables and gives a bit more informationto the compiler about our intent.
Results on M1 with 16GB:
Checklist