Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve benches #518

Merged
merged 4 commits into from
Aug 1, 2023
Merged

Improve benches #518

merged 4 commits into from
Aug 1, 2023

Conversation

MauroToscano
Copy link
Collaborator

@MauroToscano MauroToscano commented Aug 1, 2023 •
edited
Loading

General improvements for the benches

Description

  • Fix seed so results are always the same
  • Fixed all benchmarks but sqrt to use 10000 operations with random elements
  • Add the amount of operations made to the text of the benchmarks, so it's clear the time measured it's not one operation
  • Updated the text that shows which arkworks version is used

Type of change

  • New feature

@MauroToscano MauroToscano requested review from schouhy, ajgara and a team as code owners August 1, 2023 13:18
@codecov-commenter
Copy link

Codecov Report

Merging #518 (6541d74) into main (af0a479) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #518   +/-   ##
=======================================
  Coverage   94.46%   94.46%           
=======================================
  Files          62       62           
  Lines        8863     8863           
=======================================
  Hits         8372     8372           
  Misses        491      491

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

pablodeymo
pablodeymo approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@pablodeymo pablodeymo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MauroToscano MauroToscano added this pull request to the merge queue Aug 1, 2023
Merged via the queue into main with commit b856271 Aug 1, 2023
7 checks passed
@MauroToscano MauroToscano deleted the improve_benches branch August 1, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@entropidelic entropidelic entropidelic approved these changes

@diegokingston diegokingston diegokingston approved these changes

@schouhy schouhy schouhy approved these changes

@pablodeymo pablodeymo pablodeymo approved these changes

@ajgara ajgara Awaiting requested review from ajgara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MauroToscano @codecov-commenter @pablodeymo @schouhy @diegokingston @entropidelic