fix(levm): fix revert cases for contracts to run correctly #1090
+479
−125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reum_rust into levm/refactor/db
…reum_rust into levm/refactor/db
…reum_rust into levm/refactor/db
…reum_rust into levm/refactor/db
…to levm-ethereum-rust-integration
**Motivation** <!-- Why does this pull request exist? What are its goals? --> fix some things generic_call in l1 integration because of merge. **Description** <!-- A clear and concise general description of the changes this PR introduces --> <!-- Link to issues: Resolves #111, Resolves #222 --> Closes #issue_number
**Motivation** <!-- Why does this pull request exist? What are its goals? --> Eventually, we want to stop using revm and replace it with levm. The integration is a work in progress in this PR #1029. This PR aims to be the first step. It aims to prepare the current codebase so that both implementations can coexist while levm continues to be developed and does not disturb the rest of the development. When the time to remove revm comes, it'd be easier with this proposal since it'd require removing the code under the #[cfg(not(feature = "levm"))] and after that, to remove the feature flag definitively. **Description** <!-- A clear and concise general description of the changes this PR introduces --> - Adds the `levm` feature flag to the `vm` and `blockchain` packages, and to the `ethereum_rust` binary. - In `vm`, add `execute_block` implementation that uses `levm` and use it when `levm` feature flag is set. Use the original implementation if not. - In `blockchain`, add `add_block` implementation that uses `levm` and use it when `levm` feature flag is set. Use the original implementation if not. --------- Co-authored-by: Jeremías Salomón <[email protected]> Co-authored-by: JereSalo <[email protected]>
…to levm-ethereum-rust-integration
ilitteri
reviewed
Nov 6, 2024
ilitteri
reviewed
Nov 6, 2024
ilitteri
reviewed
Nov 6, 2024
Co-authored-by: Ivan Litteri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix errors encountered when trying to execute solidity contracts with LEVM.
Description
OutOfGasDisclaimer:
unwrapsout thereCloses #issue_number