-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(l2): prover_server/proposer state in file #1046
Draft
fborello-lambda
wants to merge
140
commits into
main
Choose a base branch
from
l2/prover_state_in_file
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fborello-lambda
changed the title
feat(l2): prover_client state in file
feat(l2): prover_server/proposer state in file
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Since we need to keep track of each block's zkProof and account updates, a module for creating, reading, and deleting files may be helpful for saving the blocks' state to disk.
Description
Create the module
crates/l2/utils/save_prover_state.rs
. Which provides the basics to perform read/write operations to files based on the type of information/state we need to store.At the moment there are two states:
Vec<AccountUpdate>
and thezkProof
.The structure is the one proposed in Issue #1042:
The path
ethereun_rust_l2
is placed under thedirectories::ProjectDirs::data_local_dir()
(docs).Closes #1060
Related to #1042