Skip to content

feat: Use preprocessor for native token checks. #28

feat: Use preprocessor for native token checks.

feat: Use preprocessor for native token checks. #28

Triggered via pull request February 21, 2024 11:38
Status Failure
Total duration 2m 19s
Artifacts

system-contracts-ci.yaml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 13 warnings
lint: l1-contracts/hardhat.config.ts#L31
Strings must use doublequote
lint: l1-contracts/hardhat.config.ts#L108
'path' is never reassigned. Use 'const' instead
lint: l1-contracts/hardhat.config.ts#L109
'rawData' is never reassigned. Use 'const' instead
lint: l1-contracts/hardhat.config.ts#L112
'jsonConfig' is never reassigned. Use 'const' instead
lint: l1-contracts/scripts/deploy-erc20.ts#L38
Delete `⏎`
lint: l1-contracts/scripts/deploy-erc20.ts#L58
Don't use `String` as a type. Use string instead
lint: l1-contracts/scripts/initialize-l2-weth-token.ts#L127
Replace `'--native-erc20'` with `"--native-erc20"`
lint: l1-contracts/scripts/initialize-l2-weth-token.ts#L127
Strings must use doublequote
lint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
lint: l1-contracts/contracts/bridge/L1ERC20Bridge.sol#L33
Immutable variables name are set to be in capitalized SNAKE_CASE
lint: l1-contracts/contracts/bridge/L1ERC20Bridge.sol#L90
Use Custom Errors instead of require statements
lint: l1-contracts/contracts/bridge/L1ERC20Bridge.sol#L91
Use Custom Errors instead of require statements
lint: l1-contracts/contracts/bridge/L1ERC20Bridge.sol#L93
Use Custom Errors instead of require statements
lint: l1-contracts/contracts/bridge/L1ERC20Bridge.sol#L100
Use Custom Errors instead of require statements
lint: l1-contracts/contracts/bridge/L1ERC20Bridge.sol#L101
Use Custom Errors instead of require statements
lint: l1-contracts/contracts/bridge/L1ERC20Bridge.sol#L105
Use Custom Errors instead of require statements
lint: l1-contracts/contracts/bridge/L1ERC20Bridge.sol#L106
Use Custom Errors instead of require statements
lint: l1-contracts/contracts/bridge/L1ERC20Bridge.sol#L212
Use Custom Errors instead of require statements
lint: l1-contracts/contracts/bridge/L1ERC20Bridge.sol#L214
Use Custom Errors instead of require statements
build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3, actions/cache/save@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
check-hashes
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3, actions/cache/restore@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.