chore: Initial cleanup in EvmInterpreter #98
jrchatrucAnnotations
10 errors and 5 warnings
|
lint:
l1-contracts/contracts/bridge/L1SharedBridge.sol#L133
GC: Use Custom Errors instead of require statements
|
|
lint:
l1-contracts/contracts/bridge/L1SharedBridge.sol#L177
GC: Use Custom Errors instead of require statements
|
|
lint:
l1-contracts/contracts/bridge/L1SharedBridge.sol#L279
GC: Use Custom Errors instead of require statements
|
|
lint:
l1-contracts/contracts/bridge/L1SharedBridge.sol#L280
GC: Use Custom Errors instead of require statements
|
|
lint:
l1-contracts/contracts/bridge/L1SharedBridge.sol#L290
GC: Use Custom Errors instead of require statements
|
|
lint:
system-contracts/contracts/EvmGasManager.sol#L7
global import of path ./libraries/Utils.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
|
|
lint:
system-contracts/contracts/libraries/SystemContractHelper.sol#L6
imported name Utils is not used
|
|
lint:
system-contracts/contracts/libraries/SystemContractHelper.sol#L8
imported name SystemContractsCaller is not used
|
|
lint:
system-contracts/contracts/libraries/SystemContractHelper.sol#L8
imported name CalldataForwardingMode is not used
|
|
lint:
system-contracts/contracts/libraries/SystemContractHelper.sol#L8
imported name MIMIC_CALL_CALL_ADDRESS is not used
|
|
lint
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
lint:
system-contracts/contracts/ContractDeployer.sol#L204
Avoid to use tx.origin
|
|
lint:
system-contracts/contracts/ContractDeployer.sol#L208
Avoid to use tx.origin
|
|
build
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/cache/save@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
test
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/cache/restore@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|