Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI (attempt #2). #746

Merged
merged 9 commits into from
Aug 1, 2024
Merged

Fix CI (attempt #2). #746

merged 9 commits into from
Aug 1, 2024

Conversation

azteca1998
Copy link
Collaborator

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

Copy link

github-actions bot commented Aug 1, 2024

Benchmarking results

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 11.191 ± 0.038 11.151 11.274 23.31 ± 0.08
cairo-native (embedded AOT) 1.492 ± 0.008 1.478 1.502 3.11 ± 0.02
cairo-native (embedded JIT using LLVM's ORC Engine) 1.576 ± 0.009 1.563 1.593 3.28 ± 0.02
cairo-native (standalone AOT) 0.652 ± 0.001 0.651 0.654 1.36 ± 0.00
cairo-native (standalone AOT with -march=native) 0.480 ± 0.001 0.479 0.481 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 10.637 ± 0.047 10.560 10.698 1311.22 ± 16.29
cairo-native (embedded AOT) 1.075 ± 0.005 1.069 1.082 132.52 ± 1.65
cairo-native (embedded JIT using LLVM's ORC Engine) 1.090 ± 0.009 1.080 1.110 134.36 ± 1.89
cairo-native (standalone AOT) 0.008 ± 0.000 0.008 0.009 1.04 ± 0.02
cairo-native (standalone AOT with -march=native) 0.008 ± 0.000 0.008 0.008 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 1.891 ± 0.018 1.870 1.915 28.56 ± 0.28
cairo-native (embedded AOT) 1.259 ± 0.019 1.245 1.309 19.01 ± 0.29
cairo-native (embedded JIT using LLVM's ORC Engine) 1.456 ± 0.048 1.419 1.540 21.98 ± 0.72
cairo-native (standalone AOT) 0.107 ± 0.000 0.107 0.109 1.62 ± 0.01
cairo-native (standalone AOT with -march=native) 0.066 ± 0.000 0.066 0.067 1.00

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.78%. Comparing base (3fba00d) to head (71ef291).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #746   +/-   ##
=======================================
  Coverage   91.78%   91.78%           
=======================================
  Files         121      121           
  Lines       32496    32496           
=======================================
  Hits        29827    29827           
  Misses       2669     2669           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PearsonWhite
Copy link

llvm/llvm-project#99453
Supposedly this was fixed, but it still failed for me. On my local setup, I manually downloaded llvm and set the environment variables to point to that. That might be more stable than relying on apt-get.

@azteca1998
Copy link
Collaborator Author

azteca1998 commented Aug 1, 2024

Hello, I think you might have confused our repo with LLVM's.

If not, we've also been affected by this problem but in x86_64, not ARM. The problem wasn't fixed by that issue, but there has been another one here llvm/llvm-project#101201. I can confirm that this one fixes the packaging issues in x86_64 for some distros (at least for now). More specifically, the latest ubuntu LTS (ubuntu-latest in the CI) is fixed, while debian bookworm (debian:12 on Docker) isn't yet. Debian 12 has also been fixed.

@azteca1998 azteca1998 marked this pull request as ready for review August 1, 2024 14:37
@azteca1998 azteca1998 added this pull request to the merge queue Aug 1, 2024
Merged via the queue into main with commit ec85d3d Aug 1, 2024
9 checks passed
@azteca1998 azteca1998 deleted the fix-ci branch August 1, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants