Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --terminal-prefix option #22

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Add --terminal-prefix option #22

merged 1 commit into from
Jun 25, 2024

Conversation

johanmalm
Copy link
Collaborator

@01micko Any chance you could review this one.
After this patch I'll set the version to 0.1.0

Copy link
Contributor

@01micko 01micko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the line comments LGTM - tested used 'alacritty -e' and worked for Htop :)

*-t, --terminal-prefix <command>*
Specify prefix for Terminal=true entries, for example `foot` or
`xterm -e`

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least my version pf scdoc doesn't like this syntax
Error msg:

[4/12] Generating data/labwc-menu-gene...eson to capture output, to feed input)
FAILED: data/labwc-menu-generator.1 
/usr/bin/meson --internal exe --capture data/labwc-menu-generator.1 --feed ../data/labwc-menu-generator.1.scd -- /usr/bin/scdoc
--- stderr ---
Error at 41:3: Expected ``` and a newline to begin literal block

I just patched it to get it to compile:

--- labwc-menu-generator.1.scd.orig	2024-06-25 16:39:50.319997984 +1000
+++ labwc-menu-generator.1.scd	2024-06-25 16:24:34.067284083 +1000
@@ -37,8 +37,16 @@
 	Output in pipemenu format
 
 *-t, --terminal-prefix <command>*
-	Specify prefix for Terminal=true entries, for example `foot` or
-	`xterm -e`
+	Specify prefix for Terminal=true entries, for example 
+	
+	```
+	foot
+	```
+	
+	or
+	```
+	xterm -e
+	```
 
 # AUTHORS

Copy link
Contributor

@01micko 01micko Jun 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually ignore the newlines in above patch, needless. EDIT: Sorry, s/newlines/empty lines/, :face_palm:

Copy link
Contributor

@01micko 01micko Jun 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or just use asterisks instead of back ticks. I've no set preference, didn't install so didn't test the manpage live but I don't see an issue either way.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Good catch. Have changed to normal apostrophe. Have also added scdoc to the workflow.

@01micko
Copy link
Contributor

01micko commented Jun 25, 2024

Aha, so the CI doesn't detect the scdoc problem because it's an optional dep and CI doesn't have it! I can't push a fix for that so that may require a fixup.

@johanmalm johanmalm merged commit ee3d8d0 into master Jun 25, 2024
3 checks passed
@johanmalm johanmalm deleted the terminal-prefix branch June 25, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants