Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the target SDK to 35 with the necessary changes in dependencies, permissions and execution flows #457

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

miltonials
Copy link

@miltonials miltonials commented Oct 29, 2024

This pull request includes changes to the project, focusing on updating the API level and adding changes necessary for proper operation after the new targetSDK. Key changes include updating the SDK versions, adding a new permission for foreground services and improving the code for button layout preferences and broadcast intents.

Dependency and SDK Updates:

  • Updated compileSdk and targetSdkVersion to 35 in app/build.gradle.
  • Added org.apache.commons:commons-io:1.3.2 to dependencies in app/build.gradle. This is for the successful execution of DownloadLayoutTest and DeleteLayoutTest.
  • Upgraded Gradle distribution to 8.10.1 in gradle-wrapper.properties.

Permissions:

  • Added FOREGROUND_SERVICE_LOCATION permission in AndroidManifest.xml.

Functional Enhancements:

  • Added explicit execution of the buttons presets window in Preferences.java.
  • Added getButtonsEnabled method in TrackLogger.java to know if the buttons are enabled after acquiring an accurate position fix.
  • Ensured broadcast intents are set with the package name in TrackLogger.java, TrackManager.java, and GPSLoggerServiceConnection.java.
  • Added Context.RECEIVER_NOT_EXPORTED flag to registerReceiver in GPSLogger.java.

UI and Layout:

  • Added android:key to the buttons layout preference in preferences.xml for explicit execution.

Issues solved:

…position fix is obtained

After the SDK update, UI buttons for marking waypoints remained disabled even after an accurate fix was acquired. This fix ensures that the UI buttons are enabled as soon as an accurate fix is confirmed, improving user experience in "hot start" situations.
@miltonials miltonials marked this pull request as ready for review October 29, 2024 05:40
@miltonials
Copy link
Author

Since this PR includes a Gradle update, implementing PR #448 to fix the Gradle checksum for the old version is no longer necessary.

Ensured broadcast intents are set with the package name in TagButtonOnClickListener.java, this was causing that the waypoints select meanwhile a track is recorded weren´t been saved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants