Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for unlimited audio recording by pressing headset button twice #42

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

cerisara
Copy link

Added an option to allow for "unlimited" audio recording (well, actually it is limited to a maximum of 10 minutes) by pressing the headset button twice: first to start recording, and second to stop recording. I have tested this option with a real headset, but it should also work with the touch-screen audio note button: when pressed, this button shows up a window that prints the number of seconds of recording, and a "cancel" button. When pressing this cancel button, recording stops - although I'm not sure whether the audio file is deleted or not, I'll check this also.
Anyway, the default length of 2 seconds is preserved, so that users are not surprised by a change in behaviour. I have also seen when looking at the code that there is still much to do about the "audio record" feature: listening to an audio note, deleting an audio file, exporting... I might have a look at all this if you agree, because that's the kind of feature I want to implement anyway for a (future) related project.

cerisara and others added 4 commits May 9, 2014 18:06
…top recording. Seems to work, but can definitely be improved: in particular, by letting the end-beep plays correctly when stoping
… so that users are not surprised by a change in default behavior
* Rewrite of download custom layouts functionality (close labexp#119). 

* Support android 6 permissions

* Change application icon

* Minor fixes (labexp#148)

* Notifications issue fixed, set importance at low to avoid sound. (issue on android 8)

* gradle file changed to "apply plugin" syntax (makes easier building the app for fdroid)

* set high contrast theme (issue on android 8)

* Upgrade min API to 16

* change to version 0.7, code 42
@xsaco07 xsaco07 self-assigned this Aug 23, 2018
@xsaco07
Copy link
Contributor

xsaco07 commented Sep 11, 2018

Hello, thanks for contribute to this project.

After discussing with the team we've decided to include this functionality but before that there are some things that must be made.

A few weeks ago we made some improvements in the master and develop branches with important functionalities so there are some conflicts with this pull request.

This is what we are going to do, if you agree:

  1. We'll take your pull request and make a rebase.
  2. We'll check whether the audio file is deleted or not.
  3. We'll make a pull request to your branch cerisara:master with those changes (the code up - to date).

Finally if you want to collaborate and help us to add this functionality faster you can make a pull request again, following this work-flow.

Thanks again!

@cerisara
Copy link
Author

Thank you for resurrecting this old PR, and continuing the development of this nice software.
Thanks also for the PR on my fork. I would be very glad to help, but it's been so long that I've
forgotten a lot about the code :-) and I'm really too short of time these days to get into the code.
I'm not so sure whether you're waiting for me to redo a PR on the develop branch of the main repo
with the code as it is, which I can easily do of course, but my guess is that you're rather waiting for more development from my side :-) which I pitifully cannot do right now; but I hope to be able to look back into the code later on.

Oops - and the CI failed, because of license apparently.
Thanks for considering this feature !

@xsaco07
Copy link
Contributor

xsaco07 commented Oct 20, 2018

Hello again! As I said, thanks to you for trying to improve this project!

Before continue, something important: I just made a new PR to your branch here (cerisara#2) with a minor fix I forgot. If you wanna keep helping us you can include it just as the last one.

About your doubt, in fact, what we are expecting is that you make the PR to develop with the code as it is, because the PR we made to your branch solved just compatibility-with-the-last-version issues (and a minor fix included in the last PR), that means that your contribution is able to be included as it is.

So, whenever you want!

PD: I verified whether the audio file was deleted when the user stops the recording and it doesn't, so that's OK. Maybe later we'll have to include a Cancel option and don't save the audio in that case, but by the moment this feature can be included. Of course, if you wanna contribute with this last feature we'll be thankful.

Greetings!

Minor fix - Show the recording duration
@cerisara cerisara changed the base branch from master to develop October 24, 2018 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants