-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for unlimited audio recording by pressing headset button twice #42
base: develop
Are you sure you want to change the base?
Conversation
…top recording. Seems to work, but can definitely be improved: in particular, by letting the end-beep plays correctly when stoping
… so that users are not surprised by a change in default behavior
* Rewrite of download custom layouts functionality (close labexp#119). * Support android 6 permissions * Change application icon * Minor fixes (labexp#148) * Notifications issue fixed, set importance at low to avoid sound. (issue on android 8) * gradle file changed to "apply plugin" syntax (makes easier building the app for fdroid) * set high contrast theme (issue on android 8) * Upgrade min API to 16 * change to version 0.7, code 42
Hello, thanks for contribute to this project. After discussing with the team we've decided to include this functionality but before that there are some things that must be made. A few weeks ago we made some improvements in the This is what we are going to do, if you agree:
Finally if you want to collaborate and help us to add this functionality faster you can make a pull request again, following this work-flow. Thanks again! |
Code rebase - Pull Request 43
Thank you for resurrecting this old PR, and continuing the development of this nice software. Oops - and the CI failed, because of license apparently. |
Hello again! As I said, thanks to you for trying to improve this project! Before continue, something important: I just made a new PR to your branch here (cerisara#2) with a minor fix I forgot. If you wanna keep helping us you can include it just as the last one. About your doubt, in fact, what we are expecting is that you make the PR to So, whenever you want! PD: I verified whether the audio file was deleted when the user stops the recording and it doesn't, so that's OK. Maybe later we'll have to include a Greetings! |
Minor fix - Show the recording duration
Added an option to allow for "unlimited" audio recording (well, actually it is limited to a maximum of 10 minutes) by pressing the headset button twice: first to start recording, and second to stop recording. I have tested this option with a real headset, but it should also work with the touch-screen audio note button: when pressed, this button shows up a window that prints the number of seconds of recording, and a "cancel" button. When pressing this cancel button, recording stops - although I'm not sure whether the audio file is deleted or not, I'll check this also.
Anyway, the default length of 2 seconds is preserved, so that users are not surprised by a change in behaviour. I have also seen when looking at the code that there is still much to do about the "audio record" feature: listening to an audio note, deleting an audio file, exporting... I might have a look at all this if you agree, because that's the kind of feature I want to implement anyway for a (future) related project.