Post-release patches #376
Closed
Post-release patches #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@Luthaf IDK if this needs also to do a new release, probably not given it only affects building from source. |
|
The code was building fine for me without the changes (and is building fine on main), does it still fail for you if you clone a fresh main & run |
|
Ok it actually compiles from a clean clone. I see why it does that for the packages.json, not what triggers the typescript error. I'm closing this, we can return to this at a later stage, or at least include some info in Contributing.md about packages that should be pinned, and stuff that shouldn't be touched in packages.json |
|
One of the updated depencency was the typescript compiler itself, so the old version did not understand the code anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution courtesy of chatty