Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable "more options" button in structure options by default #352

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

sofiia-chorna
Copy link
Collaborator

Bug reproduction steps:

  1. Open Chemical Shieldings in the examples in chemiscope.org
  2. Open settings in one of the grid cells
  3. Click on "more options" button near color
  4. Click on "reset min/max" button
    -> exception

image

The proposed fix is to disable "more options" initially as color property is element by default => no color bar is available

@Luthaf
Copy link
Contributor

Luthaf commented Jul 29, 2024

This looks good! One small issue I found as well is that if the user selects another coloring, then open the extra settings, and switch again to element, the options are disabled, but still visible/expanded. Maybe we should automatically collapse it when switching back to element?

@sofiia-chorna
Copy link
Collaborator Author

This looks good! One small issue I found as well is that if the user selects another coloring, then open the extra settings, and switch again to element, the options are disabled, but still visible/expanded. Maybe we should automatically collapse it when switching back to element?

@Luthaf
Thanks a lot for checking! I added a collapsing.

@Luthaf Luthaf merged commit 5a43392 into main Jul 30, 2024
6 checks passed
@Luthaf Luthaf deleted the fix-reset-color branch July 30, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants