fixed changing targets on the same tick as you attack #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously used to use the old monster's xp multiplier to predict damage if you changed target on the same tick as your attack. This change makes the predicted hit stuff run later in the tick so InteractingChanged has a chance to happen first. (similar thing used to happen with spec counter, so this should work)
|
I can't seem to reproduce the problem. Is there an easy way to reproduce it? This would also delay the xp drop by another frame so I'm not sure yet we want this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously used to use the old monster's xp multiplier to predict damage if you changed target on the same tick as your attack.
This change makes the predicted hit stuff run later in the tick so InteractingChanged has a chance to happen first.
(similar thing used to happen with spec counter, so this should work)