Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerized #99

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Dockerized #99

merged 2 commits into from
Oct 2, 2024

Conversation

codearranger
Copy link
Contributor

Checklist

  • Read CONTRIBUTING.md, and accept the CLA by including the provided snippet. We will not accept PR without this.
I, @codearranger, confirm that I have read and understood the terms of the CLA of Kyutai-labs, as outlined in the repository's CONTRIBUTING.md, and I agree to be bound by these terms.
  • Run pre-commit hook.
$ pre-commit run --all-files
flake8 on moshi package..................................................Passed
pyright on moshi package.................................................Passed
flake8 on moshi_mlx package..............................................Passed
pyright on moshi_mlx package.............................................Passed
  • If you changed Rust code, run cargo check, cargo clippy, cargo test.

PR Description

Added Dockerfiles and docker compose to run the service on a Linux with the NVIDIA Container Toolkit

Docker Server setup

Install the NVIDIA Container Toolkit

https://docs.nvidia.com/datacenter/cloud-native/container-toolkit/latest/install-guide.html

Start the docker container

docker compose up

@adefossez
Copy link
Collaborator

Could you add a section in the readme explaining how to use the docker image? Then I can accept the PR.
Thanks a lot!

@codearranger
Copy link
Contributor Author

@adefossez done

Copy link
Collaborator

@adefossez adefossez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few comments before I can merge to be sure I properly understand what is going on.

@@ -0,0 +1,40 @@
version: "3.8"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it's been removed and it's ignored now.

https://docs.docker.com/reference/compose-file/version-and-name/

pull_policy: always
restart: unless-stopped
expose:
- 43337/tcp
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not sure how the tunneling is supposed to work, is it on top of the gradio tunnel ? In that case I would remove the gradio flag in the other docker file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not on top of, but next to. I use this for all of my deployments. If you add a token then you can have a static URL on your own domain. I left it so people can have options and learn about cloudflare tunnels.

@adefossez adefossez merged commit 1fbbf36 into kyutai-labs:main Oct 2, 2024
9 checks passed
@adefossez
Copy link
Collaborator

Thanks a lot, merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants