Skip to content

Commit

Permalink
update sdk version defined in actions workflow
Browse files Browse the repository at this point in the history
  • Loading branch information
kyujin-cho committed Feb 18, 2024
1 parent 0a8a666 commit 21c7368
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/build-aab.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ jobs:
- name: Setup Android SDK
uses: android-actions/setup-android@v2
- name: Install required platform
run: sdkmanager "platforms;android-33" "build-tools;33.0.2"
run: sdkmanager "platforms;android-34" "build-tools;34.0.0"
- name: Replace android.jar
run: |
curl -L https://github.com/Reginer/aosp-android-jar/raw/main/android-33/android.jar > /usr/local/lib/android/sdk/platforms/android-33/android.jar
curl -L https://github.com/Reginer/aosp-android-jar/raw/main/android-34/android.jar > /usr/local/lib/android/sdk/platforms/android-34/android.jar
- name: Build App Bundle
id: build_aab
run: |
Expand All @@ -45,7 +45,7 @@ jobs:
- name: Sign APK
run: |
echo "${KEY_PASSWORD}" | \
$ANDROID_SDK_ROOT/build-tools/33.0.2/apksigner sign \
$ANDROID_SDK_ROOT/build-tools/34.0.0/apksigner sign \
--ks keystore.jks --ks-key-alias "${KEY_ALIAS}" \
--key-pass "env:KEY_PASSWORD" \
--out dev.bluehouse.enablevolte.aab \
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/build-apk.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ jobs:
- name: Setup Android SDK
uses: android-actions/setup-android@v2
- name: Install required platform
run: sdkmanager "platforms;android-33" "build-tools;33.0.2"
run: sdkmanager "platforms;android-34" "build-tools;34.0.0"
- name: Replace android.jar
run: |
curl -L https://github.com/Reginer/aosp-android-jar/raw/main/android-33/android.jar > /usr/local/lib/android/sdk/platforms/android-33/android.jar
curl -L https://github.com/Reginer/aosp-android-jar/raw/main/android-34/android.jar > /usr/local/lib/android/sdk/platforms/android-34/android.jar
- name: Build APK
id: build_apk
run: |
Expand All @@ -51,7 +51,7 @@ jobs:
BUILD_TYPE: ${{ inputs.build-type }}
RUN_ID: ${{ github.run_id }}
- name: align APK with zipalign
run: $ANDROID_SDK_ROOT/build-tools/33.0.2/zipalign -v -p 4 app/build/outputs/apk/${BUILD_TYPE}/${FILENAME} app-unsigned-aligned.apk
run: $ANDROID_SDK_ROOT/build-tools/34.0.0/zipalign -v -p 4 app/build/outputs/apk/${BUILD_TYPE}/${FILENAME} app-unsigned-aligned.apk
env:
BUILD_TYPE: ${{ inputs.build-type }}
FILENAME: ${{ steps.build_apk.outputs.build_filename }}
Expand All @@ -60,7 +60,7 @@ jobs:
env:
KEYSTORE_B64: ${{ secrets.keystore }}
- name: Sign APK
run: echo "${KEY_PASSWORD}" | $ANDROID_SDK_ROOT/build-tools/33.0.2/apksigner sign --ks keystore.jks --ks-key-alias "${KEY_ALIAS}" --key-pass "env:KEY_PASSWORD" --out dev.bluehouse.enablevolte.apk app-unsigned-aligned.apk
run: echo "${KEY_PASSWORD}" | $ANDROID_SDK_ROOT/build-tools/34.0.0/apksigner sign --ks keystore.jks --ks-key-alias "${KEY_ALIAS}" --key-pass "env:KEY_PASSWORD" --out dev.bluehouse.enablevolte.apk app-unsigned-aligned.apk
env:
KEY_ALIAS: ${{ secrets.key-alias }}
KEY_PASSWORD: ${{ secrets.key-password }}
Expand Down

0 comments on commit 21c7368

Please sign in to comment.