Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adjusted noisy trace filter to new istio reality #1612

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

a-thaler
Copy link
Collaborator

Description

It seems that the openTelemetry tracer of Istio changed its behaviour as the span name attribute does not contain the "ingress"|"egress" prefix anymore (#557). On that the noise filter was relying on. This PR fixes the noise filter by relying on the upstream_cluster field

Changes proposed in this pull request (what was done and why):

  • Switched the noise filter expression to rely on the istio upstream_cluster.name attribute for dtecting ingress or egress mode

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • If a CRD is changed, the corresponding Busola ConfigMap has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@a-thaler a-thaler added kind/bug Categorizes issue or PR as related to a bug. area/traces TracePipeline labels Nov 15, 2024
@a-thaler a-thaler requested a review from a team as a code owner November 15, 2024 16:45
@a-thaler a-thaler added this to the 1.28.0 milestone Nov 15, 2024
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/traces TracePipeline cla: yes Indicates the PR's author has signed the CLA. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants