Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Flatten validating webhook packages #1607

Merged
merged 8 commits into from
Nov 13, 2024

Conversation

skhalash
Copy link
Collaborator

@skhalash skhalash commented Nov 12, 2024

Description

Changes proposed in this pull request (what was done and why):

  • Merge webhook handlers with validators, replace dependency injection with helper function calls
  • Rewrite the unit tests to always call Handle and inspect the admission response
  • Rewrite http.StatusBadRequest when admission request is denied

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • If a CRD is changed, the corresponding Busola ConfigMap has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@skhalash skhalash added kind/chore Categorizes issue or PR as related to a chore. area/logs LogPipeline labels Nov 12, 2024
@skhalash skhalash added this to the 1.28.0 milestone Nov 12, 2024
@skhalash skhalash requested a review from a team as a code owner November 12, 2024 22:02
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 12, 2024
@skhalash skhalash enabled auto-merge (squash) November 12, 2024 22:02
@skhalash skhalash merged commit 9baec10 into kyma-project:main Nov 13, 2024
37 checks passed
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 13, 2024
@skhalash skhalash deleted the simplify-webhook-pkgs branch November 13, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logs LogPipeline cla: yes Indicates the PR's author has signed the CLA. kind/chore Categorizes issue or PR as related to a chore. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants