chore: Refactor logpipeline and logparser validators and the resulted…

… interdependencies (#1594)

.golangci.yaml

@@ -120,6 +120,8 @@ linters-settings:
         alias: commonStatusStubs
       - pkg: k8s.io/client-go/testing
         alias: clienttesting
+      - pkg: github.com/kyma-project/telemetry-manager/internal/utils/pipelines
+        alias: pipelineutils
   errcheck:
     check-type-assertions: true # Reports type assertions: `a := b.(SomeStruct)`.
     check-blank: true # Report assignment of errors to blank identifier: `num, _ := strconv.Atoi(numStr)`.

.testcoverage.yml

@@ -46,7 +46,9 @@ override:
   - threshold: 85
     path: ^internal/webhookcert$
   - threshold: 73
-    path: ^webhook/logpipeline
+    path: ^webhook/logpipeline$
+  - threshold: 83
+    path: ^internal/utils/pipelines$
 
 # Holds regexp rules which will exclude matched files or packages from coverage statistics
 exclude:

Makefile

@@ -112,8 +112,7 @@ manifests-dev: $(CONTROLLER_GEN) ## Generate WebhookConfiguration, ClusterRole a
 generate: $(CONTROLLER_GEN) $(MOCKERY) $(STRINGER) ## Generate code containing DeepCopy, DeepCopyInto, and DeepCopyObject method implementations.
 	$(CONTROLLER_GEN) object:headerFile="hack/boilerplate.go.txt" paths="./..."
 	$(MOCKERY)
-	$(STRINGER) --type Mode apis/telemetry/v1alpha1/logpipeline_types.go
-	$(STRINGER) --type Mode apis/telemetry/v1beta1/logpipeline_types.go
+	$(STRINGER) --type LogPipelineMode internal/utils/pipelines/logpipeline_mode.go
 	$(STRINGER) --type FeatureFlag internal/featureflags/featureflags.go
 
 .PHONY: fmt

apis/telemetry/v1alpha1/logpipeline_types.go

@@ -22,13 +22,6 @@ import (
 	"github.com/kyma-project/telemetry-manager/internal/featureflags"
 )
 
-type Mode int
-
-const (
-	OTel Mode = iota
-	FluentBit
-)
-
 //nolint:gochecknoinits // SchemeBuilder's registration is required.
 func init() {
 	SchemeBuilder.Register(&LogPipeline{}, &LogPipelineList{})