Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: clean up imports #265

Merged
merged 1 commit into from
Nov 15, 2024
Merged

refactor: clean up imports #265

merged 1 commit into from
Nov 15, 2024
+6 −9

Conversation

friedrichwilken
Copy link
Collaborator

@friedrichwilken friedrichwilken commented Nov 15, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • replace the deprecated typing.Sequence with collections.abc.Sequence
  • replace the deprecated typing.Tuple with the build in standard type tuple
  • remove unused imports and remove the corresponding #noqa instructions

Related issue(s)

@friedrichwilken friedrichwilken marked this pull request as ready for review November 15, 2024 14:33
@friedrichwilken friedrichwilken requested a review from a team as a code owner November 15, 2024 14:33
@friedrichwilken friedrichwilken changed the title refactor imports refactor: imports Nov 15, 2024
@github-actions GitHub Actions
Copy link

Note(s) for PR Auther:

  • The integration test will be skipped for the PR. You can trigger it manually after adding the label: run-integration-test.
  • The evaluation test will be skipped for the PR. You can trigger it manually after adding the label: evaluation requested.
  • If any changes are made to the evaluation tests data, make sure that the integration tests are working as expected.
  • If any changes are made to how to run the unit tests, make sure to update the steps for unit-tests in the create-release.yml workflow as well.

Note(s) for PR Reviewer(s):

  • Make sure that the integration and evaluation tests are working as expected.

@friedrichwilken friedrichwilken added evaluation requested A PR with this label will trigger the validation workflow. run-integration-test labels Nov 15, 2024
@friedrichwilken friedrichwilken changed the title refactor: imports refactor: clean up imports Nov 15, 2024
@kyma-bot kyma-bot added the lgtm label Nov 15, 2024
@kyma-bot kyma-bot merged commit a94044d into main Nov 15, 2024
43 checks passed
@friedrichwilken friedrichwilken deleted the refactor_imports branch November 15, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfaizanse mfaizanse mfaizanse approved these changes

Assignees

@mfaizanse mfaizanse

Labels
cla: yes evaluation requested A PR with this label will trigger the validation workflow. lgtm run-integration-test size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@friedrichwilken @mfaizanse @kyma-bot