Skip to content

Commit

Permalink
add review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
NHingerl committed Oct 31, 2023
1 parent e6b2380 commit 98ab078
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
8 changes: 3 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,7 @@

## Overview

Eventing Manager is a standard Kubernetes [operator](https://kubernetes.io/docs/concepts/extend-kubernetes/operator/) that observes the state of Eventing resources and reconciles their state according to the desired state.

It uses [Controllers](https://kubernetes.io/docs/concepts/architecture/controller/), which provide a reconcile function responsible for synchronizing resources until the desired state is reached on the cluster.
Eventing Manager is a standard Kubernetes [operator](https://kubernetes.io/docs/concepts/extend-kubernetes/operator/) that observes the state of Eventing resources and reconciles their state according to the desired state. It uses [Controllers](https://kubernetes.io/docs/concepts/architecture/controller/), which provide a reconcile function responsible for synchronizing resources until the desired state is reached on the cluster.

This project is scaffolded using [Kubebuilder](https://book.kubebuilder.io), and all the Kubebuilder `makefile` helpers mentioned [here](https://book.kubebuilder.io/reference/makefile-helpers.html) can be used.

Expand Down Expand Up @@ -38,7 +36,7 @@ You need a Kubernetes cluster to run against. You can use [k3d](https://k3d.io/)
make install
```

1. Run your controller (this will run in the foreground, so switch to a new terminal if you want to leave it running):
2. Run Eventing Manager. It runs in the foreground, so if you want to leave it running, switch to a new terminal.

```sh
make run
Expand Down Expand Up @@ -135,7 +133,7 @@ You need a Kubernetes cluster to run against. You can use [k3d](https://k3d.io/)

### Remove Eventing Manager from the cluster

1. To undeploy the controller from the cluster, run:
1. To undeploy the Eventing Manager from the cluster, run:

```sh
make undeploy
Expand Down
2 changes: 1 addition & 1 deletion docs/user/evnt-architecture.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ Eventing Manager manages the internal infrastructure in order to receive an even

## JetStream

Kyma now supports JetStream by default, which is a persistence offering from NATS, that guarantees `at least once` delivery. It is built-in within our default NATS backend.
The Eventing module now supports JetStream by default, which is a persistence offering from NATS, that guarantees `at least once` delivery. It is built-in within our default NATS backend.

The key advantages of JetStream over Core NATS are:

Expand Down

0 comments on commit 98ab078

Please sign in to comment.