Skip to content

Commit

Permalink
Remove t.Parallel
Browse files Browse the repository at this point in the history
  • Loading branch information
friedrichwilken committed Nov 8, 2023
1 parent 6b0c3bd commit 96690d6
Showing 1 changed file with 5 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,6 @@ func TestMain(m *testing.M) {
}

func Test_CreateEventingCR_NATS(t *testing.T) {
t.Parallel()

testCases := []struct {
name string
givenEventing *eventingv1alpha1.Eventing
Expand Down Expand Up @@ -222,7 +220,6 @@ func Test_CreateEventingCR_NATS(t *testing.T) {
}

func Test_UpdateEventingCR(t *testing.T) {
t.Parallel()
testCases := []struct {
name string
givenExistingEventing *eventingv1alpha1.Eventing
Expand Down Expand Up @@ -299,8 +296,6 @@ func Test_UpdateEventingCR(t *testing.T) {
// Test_WatcherEventingCRK8sObjects tests that deleting the k8s objects deployed by Eventing CR
// should trigger reconciliation.
func Test_WatcherEventingCRK8sObjects(t *testing.T) {
t.Parallel()

type deletionFunc func(env *testutils.TestEnvironment, eventingCR eventingv1alpha1.Eventing) error

deletePublishServiceFromK8s := func(env *testutils.TestEnvironment, eventingCR eventingv1alpha1.Eventing) error {
Expand All @@ -324,13 +319,15 @@ func Test_WatcherEventingCRK8sObjects(t *testing.T) {
}

deleteClusterRoleBindingFromK8s := func(env *testutils.TestEnvironment,
eventingCR eventingv1alpha1.Eventing) error {
eventingCR eventingv1alpha1.Eventing,
) error {
return env.DeleteClusterRoleBindingFromK8s(eventing.GetPublisherClusterRoleBindingName(eventingCR),
eventingCR.Namespace)
}

deleteHPAFromK8s := func(env *testutils.TestEnvironment,
eventingCR eventingv1alpha1.Eventing) error {
eventingCR eventingv1alpha1.Eventing,
) error {
return env.DeleteHPAFromK8s(eventing.GetPublisherDeploymentName(eventingCR),
eventingCR.Namespace)
}
Expand Down Expand Up @@ -496,7 +493,6 @@ func Test_WatcherEventingCRK8sObjects(t *testing.T) {
}

func Test_CreateEventingCR_EventMesh(t *testing.T) {
t.Parallel()
testCases := []struct {
name string
givenEventing *eventingv1alpha1.Eventing
Expand Down Expand Up @@ -609,7 +605,6 @@ func Test_CreateEventingCR_EventMesh(t *testing.T) {
}

func Test_DeleteEventingCR(t *testing.T) {
t.Parallel()
testCases := []struct {
name string
givenEventing *eventingv1alpha1.Eventing
Expand Down Expand Up @@ -721,7 +716,7 @@ func Test_DeleteEventingCR(t *testing.T) {
testEnvironment.EnsureK8sResourceCreated(t, tc.givenSubscription)
testEnvironment.EnsureSubscriptionExists(t, tc.givenSubscription.Name, tc.givenSubscription.Namespace)

//then
// then
// givenSubscription existence means deletion of Eventing CR should be blocked.
testEnvironment.EnsureK8sResourceDeleted(t, tc.givenEventing)
testEnvironment.GetEventingAssert(g, tc.givenEventing).Should(tc.wantMatches)
Expand Down Expand Up @@ -757,8 +752,6 @@ func Test_DeleteEventingCR(t *testing.T) {
}

func Test_WatcherNATSResource(t *testing.T) {
t.Parallel()

testCases := []struct {
name string
givenOriginalNats *natsv1alpha1.NATS
Expand Down

0 comments on commit 96690d6

Please sign in to comment.