Skip to content

Commit

Permalink
Add review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
grischperl committed Nov 9, 2023
1 parent a2cc14d commit 27b5110
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions docs/contributor/installation.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,12 @@ For information about the prerequisites, refer to [Development](./development.md
make deploy IMG=$IMG
```

6. To start the reconciliation process, apply the Eventing Custom Resource.
6. To start the reconciliation process, apply the Eventing custom resource (CR).
This step depends on your desired backend: NATS or EventMesh.

- **Backend: NATS**

For NATS Backend you can apply the default Custom Resource using the following command:
For NATS Backend you can apply the default CR using the following command:

```sh
kubectl apply -f config/samples/default.yaml
Expand All @@ -73,7 +73,7 @@ This step depends on your desired backend: NATS or EventMesh.

- **Backend: EventMesh**

For EventMesh Backend you can apply the default Custom Resource using the following command:
For EventMesh Backend you can apply the default CR using the following command:

```sh
kubectl apply -f config/samples/default_eventmesh.yaml
Expand Down
4 changes: 2 additions & 2 deletions docs/user/01-manager.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

This module ships Eventing Manager. Once this module is enabled, it provides the functionality to send and receive events.

## Module Lifecycle
## Module lifecycle

Upon starting Eventing Manager, the controller (following the [Kubebuilder concept](https://book.kubebuilder.io/architecture.html)) creates, watches, and reconciles the following resources:

Expand Down Expand Up @@ -31,6 +31,6 @@ Eventing Manager supports switching between two different backends. [NATS](https

For more information about the possible configuration of Eventing Manager using NATS or EventMesh backend, refer to the [backend configuration](02-configuration.md#reference).

## Removing the Module
## Removing the module

The module cannot be removed as long as Subscription CRs exist. After the user cleans up all the subscriptions, the Eventing module can be removed. The module takes care of cleaning up all resources owned by it.

0 comments on commit 27b5110

Please sign in to comment.