Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go build caching to accelerate builds #157

Merged
merged 7 commits into from
Apr 24, 2024

Conversation

DubbaThony
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Remove -a parameter from go build in Dockerfile: this will allow golang to use build caching
  • Add mount type cache to go build command in Dockerfile

This will allow to drastically cut down the building time for subsequent builds. On my local machine this changed build time from 1m 7s to 8s

Related issue(s)

None

@DubbaThony DubbaThony requested a review from a team as a code owner April 16, 2024 12:00
@CLAassistant
Copy link

CLAassistant commented Apr 16, 2024

CLA assistant check
All committers have signed the CLA.

@kyma-bot
Copy link
Contributor

Hi @DubbaThony. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kyma-bot kyma-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. labels Apr 16, 2024
@VOID404
Copy link
Contributor

VOID404 commented Apr 16, 2024

/test?

@kyma-bot
Copy link
Contributor

@VOID404: The following commands are available to trigger required jobs:

  • /test pull-compass-manager-checkconfig
  • /test pull-compass-manager-pjconfigtest
  • /test pull-compass-manager-pjtester
  • /test pull-compass-manager-vpathguard

The following commands are available to trigger optional jobs:

  • /test pre-compass-manager-presubmit-scanner

Use /test all to run the following jobs that were automatically triggered:

  • pre-compass-manager-presubmit-scanner

In response to this:

/test?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 17, 2024
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 17, 2024
VOID404
VOID404 previously approved these changes Apr 18, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 18, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Apr 22, 2024
@VOID404 VOID404 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 22, 2024
@mvshao mvshao removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2024
@kyma-bot kyma-bot merged commit 4d3a956 into kyma-project:main Apr 24, 2024
7 checks passed
@DubbaThony DubbaThony deleted the accelerate-docker-builds branch April 25, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants