Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2alpha1 CORS and Hosts #1157

Merged
merged 16 commits into from
Jul 15, 2024
Merged

v2alpha1 CORS and Hosts #1157

merged 16 commits into from
Jul 15, 2024

Conversation

barchw
Copy link
Collaborator

@barchw barchw commented Jul 10, 2024 •
edited by triffer
Loading

Description

Changes proposed in this pull request:

  • Introduce VirtualServiceProcessor for v2alpha1
  • Logic already supports multiple hosts, but using multiple is prohibited by API (which is intended because of storage version issues)
  • Add tests for CORS and hosts
  • Use new default value for CORS Policy - empty

Pre-Merge Checklist

  • As a PR reviewer, verify code coverage and evaluate if it is acceptable.

Related issues

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 10, 2024
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 10, 2024
@barchw barchw force-pushed the cors-policy-v2 branch 2 times, most recently from 9372cc9 to 9d8405e Compare July 10, 2024 12:25
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 11, 2024
@barchw barchw changed the title Cors policy v2 Cors policy v2alpha1 Jul 11, 2024
@barchw barchw changed the title Cors policy v2alpha1 v2alpha1 CORS and Hosts Jul 11, 2024
@barchw barchw marked this pull request as ready for review July 11, 2024 11:06
@barchw barchw requested a review from a team as a code owner July 11, 2024 11:06
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 11, 2024
@barchw barchw marked this pull request as draft July 11, 2024 11:23
@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 11, 2024
@barchw
Revert "Update API"
5e5d4ca 
This reverts commit 94e4eb0.
@barchw barchw marked this pull request as ready for review July 11, 2024 11:49
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 11, 2024
triffer
triffer reviewed Jul 12, 2024
View reviewed changes
internal/processing/processors/v2alpha1/test_builders_test.go Outdated Show resolved Hide resolved
internal/processing/processors/v2alpha1/virtual_service_processor.go Outdated Show resolved Hide resolved
internal/processing/processors/v2alpha1/virtual_service_processor.go Outdated Show resolved Hide resolved
internal/processing/processors/v2alpha1/virtual_service_processor.go Show resolved Hide resolved
internal/processing/processors/v2alpha1/virtual_service_processor.go Show resolved Hide resolved
internal/processing/processors/v2alpha1/virtual_service_processor_test.go Outdated Show resolved Hide resolved
internal/processing/processors/v2alpha1/virtual_service_processor.go Outdated Show resolved Hide resolved
internal/processing/processors/v2alpha1/reconciliation.go Outdated Show resolved Hide resolved
triffer
triffer previously approved these changes Jul 15, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 15, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jul 15, 2024
@triffer triffer self-requested a review July 15, 2024 12:09
@barchw barchw requested a review from a team as a code owner July 15, 2024 12:19
triffer
triffer previously approved these changes Jul 15, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 15, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jul 15, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 15, 2024
@kyma-bot kyma-bot merged commit 34e5a44 into kyma-project:main Jul 15, 2024
16 checks passed
mluk-sap added a commit to mluk-sap/api-gateway that referenced this pull request Jul 16, 2024
@mluk-sap
Merge branch 'main' into hosts-fqdn-4
f6227f4 
* main:
  v2alpha1 CORS and Hosts (kyma-project#1157)
  gomod(deps): bump github.com/gardener/external-dns-management (kyma-project#1162)
  chore: add oathkeeper log collection (kyma-project#1164)
  Add rules validation for v2alpha1 (kyma-project#1156)
  Update security scanner config (kyma-project#1163)
  bug: increase retry attempts for ory scenarios (kyma-project#1160)
  Replace all context TODO (kyma-project#1158)
  Bump cypress from 13.12.0 to 13.13.0 in /tests/ui/tests (kyma-project#1144)
  feat: more log gathering in int test jobs (kyma-project#1154)
  gomod(deps): bump golang.org/x/net from 0.26.0 to 0.27.0 (kyma-project#1145)
  Remove blank spaces (kyma-project#1152)

# Conflicts:
#	internal/validation/v2alpha1/v2alpha1.go
#	internal/validation/v2alpha1/v2alpha1_test.go
@barchw barchw deleted the cors-policy-v2 branch July 16, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nataliasitko nataliasitko nataliasitko approved these changes

@triffer triffer triffer left review comments

Assignees

@triffer triffer

@nataliasitko nataliasitko

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@barchw @kyma-bot @triffer @nataliasitko