Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix database existence check #463

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

fix database existence check #463

wants to merge 14 commits into from

Commits on Jul 9, 2020

  1. fix database existence check 

    follow up to kvesteri#372
    @bernt-matthias
    bernt-matthias committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    6e11f3f View commit details
    Browse the repository at this point in the history

  2. always dispose engine after db existence check

    @bernt-matthias
    bernt-matthias committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    36e765b View commit details
    Browse the repository at this point in the history

  3. add docs for postgres_db parameter

    @bernt-matthias
    bernt-matthias committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    743aa21 View commit details
    Browse the repository at this point in the history

  4. fix dialect_name 

    Co-authored-by: Nicola Soranzo <[email protected]>
    @bernt-matthias @nsoranzo
    bernt-matthias and nsoranzo committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    15dc668 View commit details
    Browse the repository at this point in the history

  5. optimize execution order 

    Co-authored-by: Nicola Soranzo <[email protected]>
    @bernt-matthias @nsoranzo
    bernt-matthias and nsoranzo authored Jul 9, 2020
    Configuration menu
    Copy the full SHA
    527b885 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2020

  1. database_exists fix return 

    - postgres: return for the first positive test
- use immutable for default argument
    @bernt-matthias
    bernt-matthias committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    37bb37b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'topic/372-followup' of https://github.com/bernt-matthia… 

    …s/sqlalchemy-utils into topic/372-followup
    @bernt-matthias
    bernt-matthias committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    4b396d8 View commit details
    Browse the repository at this point in the history

  3. use None as default 

    Co-authored-by: Nicola Soranzo <[email protected]>
    @bernt-matthias @nsoranzo
    bernt-matthias and nsoranzo authored Jul 15, 2020
    Configuration menu
    Copy the full SHA
    6dd16e7 View commit details
    Browse the repository at this point in the history

  4. break if successful 

    Co-authored-by: Nicola Soranzo <[email protected]>
    @bernt-matthias @nsoranzo
    bernt-matthias and nsoranzo authored Jul 15, 2020
    Configuration menu
    Copy the full SHA
    7e41e85 View commit details
    Browse the repository at this point in the history

  5. dispose only for exception

    @bernt-matthias
    bernt-matthias committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    e481582 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2020

  1. use Null connection pool and close connections 

    - use a connection (which is closed automatically) for
  data base existence check
- explicitely use Null connection pool

already with the 1st change disposal of the engine (which closes all
open connections) is not necessary anymore. with the second change
we are completely sure.
    @bernt-matthias
    bernt-matthias committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    74b3513 View commit details
    Browse the repository at this point in the history

  2. fix isort call in tox.ini and import order

    @bernt-matthias
    bernt-matthias committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    acb681c View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2020

  1. rename parameter to databases

    @bernt-matthias
    bernt-matthias committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    7908606 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2020

  1. move functions to module level

    @bernt-matthias
    bernt-matthias committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    f509f38 View commit details
    Browse the repository at this point in the history