Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): remove flake attempts on federation tests #11635

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

lahabana
Copy link
Contributor

@lahabana lahabana commented Oct 3, 2024

This should be fixed now

Fix #11420

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

This should be fixed now

Fix #11492

Signed-off-by: Charly Molter <[email protected]>
@lahabana lahabana requested a review from a team as a code owner October 3, 2024 07:45
@lahabana lahabana requested review from bartsmykla and lukidzi and removed request for a team October 3, 2024 07:46
@lahabana lahabana enabled auto-merge (squash) October 3, 2024 07:47
@lahabana lahabana disabled auto-merge October 3, 2024 07:47
@lahabana lahabana enabled auto-merge (squash) October 3, 2024 07:47
@lahabana lahabana merged commit ad7ab81 into master Oct 3, 2024
14 checks passed
@lahabana lahabana deleted the lahabana-patch-1 branch October 3, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Federation e2e test flake
2 participants