Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(meshexternalservice): prevent targeting mesh circuit breaker by validation #11476

Merged

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Sep 19, 2024

xref #11472
xrel #8417
xrel #11078

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@slonka slonka force-pushed the disable-targetting-mesh-circuit-breaker branch from fb12b54 to fa4aa70 Compare September 19, 2024 13:53
@slonka slonka marked this pull request as ready for review September 20, 2024 06:00
@slonka slonka requested a review from a team as a code owner September 20, 2024 06:00
@slonka slonka requested review from Automaat and Icarus9913 and removed request for a team September 20, 2024 06:00
@slonka slonka merged commit 3034ff6 into kumahq:master Sep 20, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants