Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TrafficRoute test is flaky #11492

Closed
Icarus9913 opened this issue Sep 20, 2024 · 2 comments
Closed

TrafficRoute test is flaky #11492

Icarus9913 opened this issue Sep 20, 2024 · 2 comments
Assignees
Labels
area/ci-cd kind/bug A bug triage/accepted The issue was reviewed and is complete enough to start working on it
Milestone

Comments

@Icarus9913
Copy link
Contributor

What happened?

This issue is used for tracing TrafficRoute e2e flaky tests:

wrong traffic split

https://github.com/kumahq/kuma/actions/runs/10943426810/job/30392838559

[FAILED] [19.664 seconds]
Traffic Route HTTP routing [It] should split traffic between internal and external destinations
github.com/kumahq/kuma/test/e2e_env/universal/trafficroute/traffic_route.go:677

Captured StdOut/StdErr Output

  [FAILED] Expected
      <map[string]int | len:2>: {"echo-v1": 64, "route-es-http": 36}
  to have {key: value} matching
      <map[interface {}]interface {} | len:1>: {
          <string>"echo-v1": <*matchers.BeNumericallyMatcher | 0x400101b080>{
              Comparator: "~",
              CompareTo: [<int>50, <int>10],
          },
      }
Error: It 09/19/24 18:16:56.687

curl exit status 22 by 40x

https://github.com/kumahq/kuma/actions/runs/10946133312/job/30392323827

[FAILED] [37.220 seconds]
Traffic Route [It] should route split traffic between the versions with 20/80 ratio
github.com/kumahq/kuma/test/e2e_env/universal/trafficroute/traffic_route.go:158

Captured StdOut/StdErr Output

  [FAILED] Timed out after 30.000s.
  The function passed to Eventually returned the following error:
      <*errors.errorString | 0xc000a024e0>: 
      stderr: '', exit status 22
      {
          s: "stderr: '', exit status 22",
      }
Error: It 09/19/24 18:30:27.61

https://github.com/kumahq/kuma/actions/runs/10943542451/job/30384877638

[FAILED] [34.363 seconds]
Traffic Route HTTP routing [It] should same splits with a different weights
github.com/kumahq/kuma/test/e2e_env/universal/trafficroute/traffic_route.go:420

Captured StdOut/StdErr Output

  [FAILED] Timed out after 30.001s.
  The function passed to Eventually returned the following error:
      <*errors.errorString | 0xc0006e0d20>: 
      stderr: '', exit status 22
      {
          s: "stderr: '', exit status 22",
      }
Error: It 09/19/24 17:19:24.789
@Icarus9913 Icarus9913 added area/ci-cd triage/pending This issue will be looked at on the next triage meeting kind/bug A bug labels Sep 20, 2024
@lahabana lahabana added this to the 2.9.x milestone Sep 20, 2024
@lahabana lahabana self-assigned this Sep 20, 2024
@lahabana
Copy link
Contributor

PR: #11496 likely removes this flakiness by always using a logical barrier to check the route is applied

@jakubdyszkiewicz jakubdyszkiewicz added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Sep 23, 2024
@jakubdyszkiewicz jakubdyszkiewicz self-assigned this Sep 23, 2024
@lahabana
Copy link
Contributor

lahabana commented Oct 3, 2024

Looks like we're done on this now right?

lahabana added a commit that referenced this issue Oct 3, 2024
This should be fixed now

Fix #11492

Signed-off-by: Charly Molter <[email protected]>
@lahabana lahabana closed this as completed Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci-cd kind/bug A bug triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Development

No branches or pull requests

3 participants