-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: remove easyjson dependency #52
refactor!: remove easyjson dependency #52
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! I'm looking forward to have this merged.
Could you also add a quick comparison about the following changes, before and after this PR (basically easyjson
vs encoding/json
):
- size of the
.wasm
module - performance comparison (you can use
kwctl bench
for that)
README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you do the following changes:
- update the date at the beginning of the file
- update the section limitations explaining the limitations of tinygo (reflection is now supported)
- mention we need tinygo 0.28.1 or later - otherwise the code compiles but will panic at runtime
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@flavio i've updated the README
Could you also add a quick comparison about the following changes, before and after this PR (basically easyjson vs encoding/json):
I've added this to the PR description.
2f28788
to
924b925
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, modulo de pending local replace of policy-sdk-go
Signed-off-by: Fabrizio Sestito <[email protected]>
Signed-off-by: Fabrizio Sestito <[email protected]>
Signed-off-by: Fabrizio Sestito <[email protected]>
Signed-off-by: Fabrizio Sestito <[email protected]>
Signed-off-by: Fabrizio Sestito <[email protected]>
Signed-off-by: Fabrizio Sestito <[email protected]>
924b925
to
5af26d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, this can be merged 👏
Description
This PR removes easyjson dependency from the mix by refactoring the example/template policy.
Also, it bumps the build container to
tinygo:0.28.1
.Test
Existing tests should pass
Additional Information
Size comparison
before:
after:
Benchmarks
kwctl bench
resultsbefore:
after:
kwctl bench --warm-up-time 1 --measurement-time 1 --num-resamples 2 --num-samples 2
resultsbefore:
after: