Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: regenerate vendor files #1024

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

akrejcir
Copy link
Collaborator

What this PR does / why we need it:
Run "go mod tidy && go mod vendor" in the project root directory.

Release note:

None

Run "go mod tidy && go mod vendor" in the project root
directory.

Signed-off-by: Andrej Krejcir <[email protected]>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jul 31, 2024
@akrejcir
Copy link
Collaborator Author

/cc @ksimon1 @0xFelix

@ksimon1
Copy link
Member

ksimon1 commented Jul 31, 2024

/lgtm
btw. how is possible, that this slip through the e2e tests?

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2024
@akrejcir
Copy link
Collaborator Author

Good question. I'm not sure.

Copy link

sonarcloud bot commented Jul 31, 2024

Copy link
Member

@codingben codingben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

This is really weird that it didn't catch this issue in the CI.

@ksimon1
Copy link
Member

ksimon1 commented Jul 31, 2024

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ksimon1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2024
@kubevirt-bot kubevirt-bot merged commit 225b61f into kubevirt:main Jul 31, 2024
12 of 13 checks passed
@akrejcir akrejcir deleted the update-vendor-files branch July 31, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants