Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add renovate config #1020

Closed
wants to merge 1 commit into from
Closed

Conversation

ksimon1
Copy link
Member

@ksimon1 ksimon1 commented Jul 29, 2024

What this PR does / why we need it:
Add renovate configuration, which updates main and release branches. release branches are configure to have only security patches.

This config was tested on: https://github.com/ksimon1/ssp-operator/pulls
Release note:

NONE

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jul 29, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ksimon1. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ksimon1
Copy link
Member Author

ksimon1 commented Jul 29, 2024

/hold we need to wait until the repo is onboarded to renovate

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 29, 2024
@ksimon1
Copy link
Member Author

ksimon1 commented Jul 29, 2024

/cc @akrejcir

renovate.json Show resolved Hide resolved
]
},
{
"matchPackageNames":[
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the docs: https://docs.renovatebot.com/configuration-options/#matchpackagenames
matchPackageNames should contain names of packages. Is golang a special name for the compiler version?

renovate.json Outdated
"release-v0.17"
],
"constraints":{
"go":"1.22"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Older branches use older go versions. Can we configure this constraint for each branch?

renovate.json Show resolved Hide resolved
renovate.json Outdated Show resolved Hide resolved
renovate.json Outdated Show resolved Hide resolved
@ksimon1 ksimon1 force-pushed the onboard-renovate branch 2 times, most recently from 40b8a19 to e8c34c3 Compare July 29, 2024 13:25
Add renovate configuration, which updates main and release branches.
release branches are configure to have only security patches.

Signed-off-by: Karel Simon <[email protected]>
Copy link

sonarcloud bot commented Jul 29, 2024

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 2, 2024
@kubevirt-bot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ksimon1 ksimon1 closed this Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants