Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update common-templates to v0.29.2 #1016

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Update common-templates to v0.29.2 #1016

merged 1 commit into from
Jul 26, 2024

Conversation

ksimon1
Copy link
Member

@ksimon1 ksimon1 commented Jul 25, 2024

Update common-templates bundle to v0.29.2
Release note:

Update common-templates bundle to v0.29.2

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jul 25, 2024
@ksimon1
Copy link
Member Author

ksimon1 commented Jul 26, 2024

/cherrypick release-v0.20

@kubevirt-bot
Copy link
Contributor

@ksimon1: once the present PR merges, I will cherry-pick it on top of release-v0.20 in a new PR and assign it to you.

In response to this:

/cherrypick release-v0.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ksimon1
Copy link
Member Author

ksimon1 commented Jul 26, 2024

@geetikakay, @kbidarkar FYI we will be backporting the removal of win2k12 template to 4.16

@akrejcir
Copy link
Collaborator

Adding renovate is unrelated to this PR. Can you please split it?
We have multiple PRs that update common-templates already, and it is unexpected to find another change in the same PR.

@ksimon1
Copy link
Member Author

ksimon1 commented Jul 26, 2024

I am testing renovate on my local fork :) The automation took my main with renovate config, I will remove it.

@ksimon1
Copy link
Member Author

ksimon1 commented Jul 26, 2024

/hold

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 26, 2024
@ksimon1 ksimon1 force-pushed the update-common-templates-v0.29.2 branch from 8da8bd5 to 3daf5e6 Compare July 26, 2024 07:12
@ksimon1
Copy link
Member Author

ksimon1 commented Jul 26, 2024

/hold cancel

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 26, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ksimon1
Copy link
Member Author

ksimon1 commented Jul 26, 2024

@akrejcir fixed

@jcanocan
Copy link
Contributor

Thanks @ksimon1!
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2024
@akrejcir
Copy link
Collaborator

Thanks.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akrejcir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2024
@kubevirt-bot kubevirt-bot merged commit f07c13c into kubevirt:main Jul 26, 2024
12 checks passed
@kubevirt-bot
Copy link
Contributor

@ksimon1: new pull request created: #1017

In response to this:

/cherrypick release-v0.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot kubevirt-bot mentioned this pull request Jul 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcanocan jcanocan Awaiting requested review from jcanocan

@opokornyy opokornyy Awaiting requested review from opokornyy

Assignees

@jcanocan jcanocan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ksimon1 @kubevirt-bot @akrejcir @jcanocan