OpenSUSE: Add major version latest tags #150
Conversation
kubevirt-bot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Lee Yarwood <[email protected]>
With the introduction of a 15-latest tag we can stop syncing this older release and just focus on >= 15.6 now. Signed-off-by: Lee Yarwood <[email protected]>
Signed-off-by: Lee Yarwood <[email protected]>
lyarwood
force-pushed
the
opensuse-add-additionaltags
branch
from
7c46589
to
8f91aa1
Compare
| SHA256Sum: "0f7f09a9a083088b51aa365fe0e4310e6b156c2153d6aa03a77b81eee884e52a", | ||
| DownloadURL: "https://download.opensuse.org/distribution/leap/15.6/appliances/openSUSE-Leap-15.6-Minimal-VM.x86_64-Cloud.qcow2", | ||
| ImageArchitecture: "amd64", | ||
| AdditionalUniqueTags: []string{"15-latest"}, |
There was a problem hiding this comment.
Won't this break when defining multiple artifacts of leap?
There was a problem hiding this comment.
If we defined multiple of the same major version but as suggested by the follow up commit removing 15.5 I'm not sure we want to do that?
There was a problem hiding this comment.
Otherwise I can pass the 15-latest tag into New and only provide it to the actual latest minor version we are syncing?
There was a problem hiding this comment.
I didn't think of it earlier, but can you make it figure out the latest minor version by itself? Similar to how versions of Fedora are gathered? This way we could avoid looking for new minor versions manually.
kubevirt-bot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: