Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter nodes based on pods selectors #48

Conversation

moadqassem
Copy link

@moadqassem moadqassem commented Mar 30, 2022

This PR solves the issue of network traffic forwarding from the load balancer service to the right nodes where the pods that are selected are running. When the externalTrafficPolicy Local is used, then traffic would be only go south-west not east-west which means, if the traffic goes to a node where the selected pod doesn't exists, this request will fail.

Fixes #41

Signed-off-by: Moath Qasim <[email protected]>

Signed-off-by: Moath Qasim <[email protected]>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 30, 2022
@kubevirt-bot
Copy link
Contributor

Hi @moadqassem. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign davidvossel after the PR has been reviewed.
You can assign the PR to them by writing /assign @davidvossel in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@moadqassem moadqassem changed the title filter nodes based on pods selectors Filter nodes based on pods selectors Mar 30, 2022
@moadqassem moadqassem closed this Apr 3, 2022
@moadqassem moadqassem deleted the fix-node-labeling-based-on-pod-selectors branch April 3, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants