feat: Add SIG specific badges for e2e failures against merged PRs #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian Carey <[email protected]>
Signed-off-by: Brian Carey <[email protected]> fix: Update metrics package to use newer text format expfmt.FmtText is no longer exported in new prometheus/common modules[1] [1] prometheus/common@05d7387 Signed-off-by: Brian Carey <[email protected]>
kubevirt-bot
added
the
dco-signoff: yes
… PRs Signed-off-by: Brian Carey <[email protected]>
Signed-off-by: Brian Carey <[email protected]>
Signed-off-by: Brian Carey <[email protected]>
Badges generated by running:
```
bazelisk run //cmd/stats -- --gh-token ${GH_TOKEN} --source kubevirt/kubevirt --path ${SRC}/ci-health/output/ --data-days 7
```
Signed-off-by: Brian Carey <[email protected]>
brianmcarey
force-pushed
the
failures-per-sig
branch
from
6bd7208
to
4bb0503
Compare
dhiller
reviewed
Jul 23, 2024
| } | ||
|
|
||
| func getFailedJobsForLatestCommit(org string, repo string, prNumber string) (failedJobs []failedJob, err error) { | ||
| prHistory := prHistoryURL(org, repo, prNumber) |
There was a problem hiding this comment.
This is interesting - I have never thought about scraping the history page directly... I could imagine reusing that for metrics that we might want to shove into the prometheus.
👍
Signed-off-by: Brian Carey <[email protected]>
dhiller
approved these changes
Jul 24, 2024
|
@brianmcarey hm, I don't see the badges yet - I figure they will appear with the next run? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
These badges count the number of e2e lane failures per SIG against the last code push for all kubevirt/kubevirt merged PRs over the last 7 days.
These failures contribute directly to delays in merges and to the number of retests that occur in CI.
If a SIG is responsible for more then 20 of these failures, the badge will be marked as red. Yellow for failures above 1 and green for below that.
Badges from a recent manual run are included as part of this PR.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
/cc @dhiller @xpivarc
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note: