Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: extract Control Plane compatible with OSS version #5957

Merged
merged 17 commits into from
Oct 25, 2024
Merged

feat: extract Control Plane compatible with OSS version #5957

merged 17 commits into from
Oct 25, 2024

Conversation

rangoo94
Copy link
Member

@rangoo94 rangoo94 commented Oct 22, 2024 •
edited
Loading

Pull request description

  • Extract Control Plane compatible with OSS version
    • The system will either connect to Cloud or local Control Plane - won't interact with database or Object Storage different way
    • Exception: Legacy Tests and Test Suites may interact directly with the Object Storage to store/read artifacts - to avoid breaking changes for not-compatible features (ArtifactRequest.StorageBucket and ArtifactRequest.OmitFolderPerExecution)
  • Isolated a bit more deprecated resources
    • We will be able to make feature flag / environment variable to gracefully disable deprecated features

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

@rangoo94 rangoo94 requested a review from a team as a code owner October 22, 2024 12:49
@rangoo94 rangoo94 mentioned this pull request Oct 22, 2024
Merged
6 tasks
vsukhin
vsukhin reviewed Oct 23, 2024
View reviewed changes
pkg/controlplane/server.go Outdated Show resolved Hide resolved
vsukhin
vsukhin reviewed Oct 23, 2024
View reviewed changes
pkg/controlplane/server.go Outdated Show resolved Hide resolved
@rangoo94 rangoo94 merged commit 3b83571 into main Oct 25, 2024
6 checks passed
@rangoo94 rangoo94 deleted the dawid/feat/extract-control-plane branch October 25, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsukhin vsukhin vsukhin approved these changes

@povilasv povilasv povilasv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rangoo94 @vsukhin @povilasv