Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: provide workflow name to parallel workers, so it will properly build path for artifacts #5953

Merged
merged 1 commit into from
Oct 21, 2024
Merged

fix: provide workflow name to parallel workers, so it will properly build path for artifacts #5953

merged 1 commit into from
Oct 21, 2024

Conversation

rangoo94
Copy link
Member

Pull request description

  • Provide workflow name down
  • Simplify artifacts path for parallel workers (<ref>/<index> instead of <ref>/<ref>-<index>)
  • Ensure de-registering controllers in Execution Worker works fine (encountered issue once)

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

@rangoo94 rangoo94 requested a review from a team as a code owner October 21, 2024 15:27
@rangoo94 rangoo94 merged commit e3b49ef into main Oct 21, 2024
21 checks passed
@rangoo94 rangoo94 deleted the dawid/fix/saving-artifacts-from-parallel-workers branch October 21, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsukhin vsukhin vsukhin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rangoo94 @vsukhin