Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: detecting service IPs and fetching logs #5952

Merged
merged 2 commits into from
Oct 21, 2024
Merged

fix: detecting service IPs and fetching logs #5952

merged 2 commits into from
Oct 21, 2024

Conversation

rangoo94
Copy link
Member

Pull request description

  • Add missing correlation group for services
    • So they can be gracefully cleaned up, and logs fetched
  • Save the state file (with output) before execution
    • So Toolkit can always access service IPs

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

@rangoo94 rangoo94 marked this pull request as ready for review October 21, 2024 13:18
@rangoo94 rangoo94 requested a review from a team as a code owner October 21, 2024 13:18
@rangoo94 rangoo94 merged commit 24abeeb into main Oct 21, 2024
21 checks passed
@rangoo94 rangoo94 deleted the dawid/fix/services-ids-and-ips branch October 21, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsukhin vsukhin vsukhin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rangoo94 @vsukhin