Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure there is a service IP available before marking as started #5766

Merged
merged 1 commit into from
Aug 15, 2024
Merged

fix: ensure there is a service IP available before marking as started #5766

merged 1 commit into from
Aug 15, 2024

Conversation

rangoo94
Copy link
Member

Pull request description

  • There was a race condition, where the container may be marked as started, while pod has not registered yet its IP in Testkube

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

@rangoo94 rangoo94 requested a review from a team as a code owner August 15, 2024 11:56
@rangoo94 rangoo94 merged commit 25dc8a2 into develop Aug 15, 2024
20 checks passed
@rangoo94 rangoo94 deleted the dawid/fix/services-may-have-ips-missing branch August 15, 2024 11:59
rangoo94 added a commit that referenced this pull request Aug 15, 2024
@rangoo94
fix: ensure there is a service IP available before marking as started (…
b88bc0a 
…#5766)
@rangoo94 rangoo94 mentioned this pull request Aug 15, 2024
Merged
6 tasks
rangoo94 added a commit that referenced this pull request Aug 15, 2024
@rangoo94
fix: ensure there is a service IP available before marking as started (…
c4642ff 
…#5766)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ed382 ed382 ed382 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rangoo94 @ed382