Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testworkflows): displaying events #5652

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Conversation

rangoo94
Copy link
Member

Pull request description

  • 999999 in Golang time format is not displaying the nanoseconds in case they are 0; it leads to incorrect length while formatting the time for events in logs, so the UI is not able to display them correctly.

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

@rangoo94 rangoo94 requested a review from a team as a code owner July 11, 2024 08:47
Copy link

netlify bot commented Jul 11, 2024

Deploy Preview for testkube-docs-preview canceled.

Name Link
🔨 Latest commit 870ba91
🔍 Latest deploy log https://app.netlify.com/sites/testkube-docs-preview/deploys/668f9c14752f1c0008cf5997

@rangoo94 rangoo94 merged commit 7021e06 into develop Jul 11, 2024
11 checks passed
@rangoo94 rangoo94 deleted the dawid/fix/displaying-events branch July 11, 2024 08:59
ed382 pushed a commit that referenced this pull request Jul 11, 2024
ed382 pushed a commit that referenced this pull request Jul 11, 2024
vsukhin added a commit that referenced this pull request Jul 16, 2024
* fix(testworkflows): displaying events (#5652)

* feat: remove test workflow notifications

Signed-off-by: Vladislav Sukhin <[email protected]>

* fix: remove duplicated param

Signed-off-by: Vladislav Sukhin <[email protected]>

* featL refactor disable webhooks

Signed-off-by: Vladislav Sukhin <[email protected]>

* fix: dep update

Signed-off-by: Vladislav Sukhin <[email protected]>

* fix: add deprecated cli param

Signed-off-by: Vladislav Sukhin <[email protected]>

* fix: update docs

Signed-off-by: Vladislav Sukhin <[email protected]>

* fix: remove enable flag

Signed-off-by: Vladislav Sukhin <[email protected]>

* fix: update webhooks docs

Signed-off-by: Vladislav Sukhin <[email protected]>

* fix: add disable webhooks to execution

Signed-off-by: Vladislav Sukhin <[email protected]>

* fix: show more fields in twe

Signed-off-by: Vladislav Sukhin <[email protected]>

* fix: pass disable webhooks for test suites

Signed-off-by: Vladislav Sukhin <[email protected]>

* fixL format execution output

Signed-off-by: Vladislav Sukhin <[email protected]>

* fix: pass disable webhooks flag to execute operation

Signed-off-by: Vladislav Sukhin <[email protected]>

* fix: rename var

Signed-off-by: Vladislav Sukhin <[email protected]>

* fix: dep update

Signed-off-by: Vladislav Sukhin <[email protected]>

---------

Signed-off-by: Vladislav Sukhin <[email protected]>
Co-authored-by: Dawid Rusnak <[email protected]>
vsukhin added a commit that referenced this pull request Jul 23, 2024
* fix(testworkflows): displaying events (#5652)

* feat: remove test workflow notifications

Signed-off-by: Vladislav Sukhin <[email protected]>

* fix: remove duplicated param

Signed-off-by: Vladislav Sukhin <[email protected]>

* featL refactor disable webhooks

Signed-off-by: Vladislav Sukhin <[email protected]>

* fix: dep update

Signed-off-by: Vladislav Sukhin <[email protected]>

* fix: add deprecated cli param

Signed-off-by: Vladislav Sukhin <[email protected]>

* fix: update docs

Signed-off-by: Vladislav Sukhin <[email protected]>

* fix: remove enable flag

Signed-off-by: Vladislav Sukhin <[email protected]>

* fix: update webhooks docs

Signed-off-by: Vladislav Sukhin <[email protected]>

* fix: add disable webhooks to execution

Signed-off-by: Vladislav Sukhin <[email protected]>

* fix: show more fields in twe

Signed-off-by: Vladislav Sukhin <[email protected]>

* fix: pass disable webhooks for test suites

Signed-off-by: Vladislav Sukhin <[email protected]>

* fixL format execution output

Signed-off-by: Vladislav Sukhin <[email protected]>

* fix: pass disable webhooks flag to execute operation

Signed-off-by: Vladislav Sukhin <[email protected]>

* fix: rename var

Signed-off-by: Vladislav Sukhin <[email protected]>

* fix: dep update

Signed-off-by: Vladislav Sukhin <[email protected]>

---------

Signed-off-by: Vladislav Sukhin <[email protected]>
Co-authored-by: Dawid Rusnak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants